feat: Add subdialog support to Menu and Autocomplete #7561
yihuiliao
merged
68 commits into
main
from
subdialogs
Base automatically changed from
autocomplete_audit_for_release
to
main
1 year ago
rough start
db04fecc
fix contain
2f7cb820
debug ESC handler
c3fece18
fix rendering of subdialog in autocomplete
34ab7032
debug dynamic case and fix context
e63c5fde
handle submenutriggers in base collection filtering and fix id issue …
5e3fb0b5
prevent focus from being lost to the body when submenutrigger is virt…
30e6762e
ensure that the focused subdialogtrigger item remains focused after o…
c4fc7722
close submenu when virtual focus moves off trigger and properly dispa…
19f9eaad
Merge branch 'main' of github.com:adobe/react-spectrum into subdialogs
222807e4
fix hover for now so I can debug the focus issues
b3f3ecdf
fix tab handling in subdialogs and opening submenus on mobile when us…
931c28e3
Fix to close submenus/dialogs when in a Autocomplete that isnt in a p…
fdc40c57
fix issue where you cant shift tab from the Autocompletes text field
a1bd7f54
fix shift tabbing from closing the subdialogs when rendered by Autoco…
cc954c2e
Merge branch 'main' into subdialogs
016bb1a3
make sure expanded triggers dont have visible focus ring
2e581cf8
fix all subdialog being closed when using ESC on a subMenuTrigger and…
f27a7664
update mobile screen reader behavior so focus is restored to the subt…
5cb78be4
only close outer most submenu/subdialog when using ESC
a2c87edc
partial fix to only persist a single focus ring on item or input for …
43ab42f3
Making focus ring appear on virtually focused items and on input fiel…
7f4a779d
Merge branch 'main' into subdialogs
19251e12
LFDanLu
commented
on 2025-01-24
LFDanLu
commented
on 2025-01-24
LFDanLu
commented
on 2025-01-24
simplifiying useSelectableItem change in favor of proper manager.isFo…
7af516b6
LFDanLu
commented
on 2025-01-24
LFDanLu
commented
on 2025-01-24
LFDanLu
commented
on 2025-01-24
Merge branch 'main' into subdialogs
61d812ae
saving point for tests
9922dd7a
Fix focusscope for subdialogs and add test
fec56ff3
Fix S2 autocomplete double focus ring
d1e9eef1
adding tests for subdialog and testing useInteractOutside for subdial…
eab66a8d
add submenu tests
0d2f41dc
fix ESC closing multiple levels of subdialogs/menus due to collection…
5a32a08f
hack around react 16 failures for now
04a1782a
fix lint
dbee21e2
Merge branch 'main' of github.com:adobe/react-spectrum into subdialogs
0198298b
fix react 16, close menu on hovering different item
14e74038
fixing lint
b81d9dde
LFDanLu
changed the title
LFDanLu
changed the title
wip: refactor to fire fake focus/blur events
9b81a2c0
fix more
ca935d78
implement keepVisible for non-modal popovers
237b30ec
refactor
426681e5
update lock
0dc6d84a
lint
4b3bc0c5
fix 16
6d5cec9f
fix test
e66a8e23
Clear MenuContext in SubDialog
5b498894
Fix dismiss on interact outside
f6b72721
Use focusedNodeId ref for keyboard handlers to avoid race condition
0b75f856
refactor listbox filtering to support usage inside Select
a5573cd6
Make sure props are sent to the right elements
65b105eb
fix RSP
77148f5b
cleanup
1e394d23
fix react 16/17
e03daa4f
Revert "fix react 16/17"
30c517c7
Revert "fix RSP"
46c90a07
Revert "Fix dismiss on interact outside"
057f60cc
Fix interact outside for RAC submenu/subdialogs specifically
506312f0
Merge branch 'subdialogs-devon' into subdialogs
7862d51b
revert dialog change
1eaa17cc
devongovett
commented
on 2025-02-13
more cleanup
3fae6bef
Merge branch 'main' of github.com:adobe/react-spectrum into subdialogs
43b35956
Use getActiveElement utility
3929cef5
focus input when clicking on collection
7fd803a4
fix merge
08b8c1a6
Refactor left/right arrow key behavior to be less menu specific
dc2dbb4c
Remove onDismissButtonPress for now
6d3d3772
lint
7be3d105
Merge branch 'main' of github.com:adobe/react-spectrum into subdialogs
3dee0949
snowystinger
dismissed these changes
on 2025-02-19
Merge branch 'main' of github.com:adobe/react-spectrum into subdialogs
8f6724f0
snowystinger
approved these changes
on 2025-02-20
dannify
approved these changes
on 2025-02-20
Reviewers
Assignees
No one assigned
Labels
release
in sprint
Milestone
No milestone
Login to write a write a comment.
Login via GitHub