PR #7938 feat: Async loading support for S2 ComboBox/Picker

initial support for async loading in Combobox/picker/listbox in RAC

c4ca76d7

test against Listbox standalone and put on content size change issue

8ee20f9a

update S2 CardView/RAC GridList for new useLoadMore

c2a1cf97

fix v3 load more stories and tests

765b7574

update table to call useLoadMore internally

7708b81e

first attempt at refactoring useLoadmore

2da7d040

refactor useLoadMore to get rid of scroll handlers

0bb9f216

Add S2 Picker async support, support horizontal scrolling, fix types …

00491539

async support for S2 combobox

76e1a05f

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

68033b2b

fix lint and add horizontal scrolling story

54fcbaa1

hack together async listbox virtualized example

4d3bb6c4

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

f6ba68a2

add loading spinners to RAC stories

3fe09f6b

fix FF load more resizable wrapping container table, make s2 picker l…

0b06824b

update S2 Picker/Combobox so they are described by loading spinner

da166f29

fix Talkback and NVDA announcements for loading spinner

0ef52efd

LFDanLu added in sprint

LFDanLu changed the title ~~feat: (WIP) Async loading support for S2 ComboBox and Picker~~ feat: (WIP) Async loading support for S2 ComboBox/Picker and multilevel Tree loading 183 days ago

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

51580d77

clean up some todos

76dc08ab

LFDanLu force pushed from f9aea936 to 76dc08ab 182 days ago

LFDanLu changed the title ~~feat: (WIP) Async loading support for S2 ComboBox/Picker and multilevel Tree loading~~ feat: Async loading support for S2 ComboBox/Picker 182 days ago

LFDanLu marked this pull request as ready for review 182 days ago

LFDanLu commented on 2025-04-10

set overflow to visible on ListLayout

27260f4c

add useLoadMoreSentinel instead of changing useLoadMore

41a28cbe

refactor useLoadMore and update RAC components load more

4fb8aeb8

add separator height to list layout

f8b1745a

change css for picker and combobox

b2724698

Merge branch 'main' into s2-combobox-picker-virtualizer

7a2877cb

fix s2 combobox and picker

4c5bc69f

fix separator height

5c423d40

fix picker's separator

fdf423fa

cleanup

711dff6e

Merge branch 'main' into s2-combobox-picker-virtualizer

286d8b81

update yarn lock

0938fb99

update S2 CardView and TableView for new loading sentinel refactor

1eeb7982

fix lint

5fc224f2

remove workflow dependency

18c65b2b

remove style from s1 theme oops

85b7edbe

fix lint

7f575067

picker fixes

d493fc41

picker cleanup

a69a7943

fix lint

4523888d

fix line height in header

30520014

properly persist table loading spinner in virtualized case

6a98ac53

fix listbox and gridlist persisted sentinel and fix double spinners

6fb2c01f

stray console log

97b21a2d

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

e1bd8f3d

fix react 19 tests

d4bec98e

fix lint?

7f062b80

persist sentinel in card layouts

561d9148

forgot to fix waterfall empty state

dc6e80a7

Merge branch 'main' into s2-combobox-picker-virtualizer

0c3a3b49

get rid of extranous space when listbox/table loaded all of the avail…

2085f8c7

fix empty state for S2 ComboBox and make sure S2 Picker doesnt open w…

a9b7ea61

Merge branch 's2-combobox-picker-virtualizer' of github.com:adobe/rea…

f60cbe3b

fix scroll offset issue after loadMore operations finish in virtualiz…

0fa17ccd

dont reserve room for the isLoadingMore spinner if performing initial…

95beec71

LFDanLu commented on 2025-04-24

add translations and clean up

fc193c59

get rid of flex: none since loader is part of virtualized collection

cbd91b5e

fix lint

4a62993d

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

f664da04

LFDanLu commented on 2025-04-24

update grid areas and fix edgeToText

85440fc2

LFDanLu commented on 2025-04-24

prevent the empty w/ loading sentinel select from opening on arrow down

09825f4e

adding chromatic tests for S2 Combobox/Picker async loading

d98691f7

making sure sentinel is rendered even when empty

f34fc0ce

update gridlist stories so that it is easier to see useLoadMore is on…

abfcde02

add gridlist tests for loadmore

5258d8ba

Merge branch 'main' into s2-combobox-picker-virtualizer

48caf942

fix install?

379fba7b

fix sizes

160e9a0f

fix lint

fac19205

update ScrollView to fix ComboBox tests

f87438b4

refactor to use collection instead of isLoading in useLoadMoreSentinel

7c5f1e8f

update getItemCount so it doesnt include loaders in custom announcements

63db21ee

make sure listbox doesnt add extranous padding above the empty state …

1eb421eb

add listbox and table tests

15bc7d1f

fix delay when opening many items S2 select

77b4b62f

sorta get selected item to scroll into view virtualized

1bbd69c0

fix tests

bebc44bd

cleanup fix lint

9976091e

more cleanup

9c51d0de

fix picker tests

f7a1e206

fix collection index incrementing when performing insertBefore

53f9158b

Merge branch 'main' into select-scrollview

ebba44e8

fix tests and lint

4755b916

Merge branch 's2-combobox-picker-virtualizer' of github.com:adobe/rea…

5e8b6aef

update test-util dev dep in S2 so 16/17 tests pass

e2b8c002

forgot yarn lock change

a0b9e5dd

LFDanLu added release

fix overflow on windows potentially...

cb52f58d

Merge branch 'select-scrollview' of https://github.com/adobe/react-sp…

112df590

fix rowindex calculation when filtering async s2 combobox

be7d2336

make S2 picker button not throw warning when rending in fake DOM

69b7db17

fix s2 picker scroll selected item into view

3cbb286f

fix lint

923e260c

LFDanLu commented on 2025-05-06

clean up and add row index tests for GridList and Table

a2049ab7

small improvements from testing session

65c2aca4

LFDanLu commented on 2025-05-06

update yarn lock

01ead632

remove comment

3ae8f294

snowystinger commented on 2025-05-07

devongovett commented on 2025-03-17

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

32c3792e

review comments

16808857

Merge branch 's2-combobox-picker-virtualizer' of github.com:adobe/rea…

935e4396

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

8bd923f1

missed yarn.lock conflict

f4e5f0de

fix picker test

a69f298e

mixed up which react-dom dep to remove derp

67423b25

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

52e04bc0

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

fb0aff35

fix Combobox test so it properly catches previous Document bug

f35df51d

Merge branch 'main' of github.com:adobe/react-spectrum into loadmore_rac

4637d343

fix cases where extra separators appeared on combobox filter/if load …

b9e2ad76

marking the document as dirty when _minInvalidChildIndex is changing

875d9a3f

reidbarber dismissed these changes on 2025-05-09

devongovett dismissed these changes on 2025-05-09

get rid of extra todos and obsolte test

9026acb7

LFDanLu dismissed their stale review via 9026acb7 152 days ago

devongovett approved these changes on 2025-05-09

LFDanLu enabled auto-merge 152 days ago

dannify approved these changes on 2025-05-09

LFDanLu merged e9bd3a3c into main 152 days ago

LFDanLu deleted the loadmore_rac branch 152 days ago

react-spectrum
feat: Async loading support for S2 ComboBox/Picker
#7938

Merged

feat: Async loading support for S2 ComboBox/Picker #7938

react-spectrum feat: Async loading support for S2 ComboBox/Picker #7938 Merged

feat: Async loading support for S2 ComboBox/Picker #7938

react-spectrum
feat: Async loading support for S2 ComboBox/Picker
#7938

Merged