react-spectrum
fix: documentation select placeholder default
#7941
Merged
Overview
Commits
5
Changes
View On GitHub

fix: documentation select placeholder default #7941

LFDanLu merged 5 commits into main from default-select-placeholder
snowystinger
snowystinger156 days ago

Closes

โœ… Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

๐Ÿ“ Test Instructions:

๐Ÿงข Your Project:

snowystinger fix: documentation select placeholder default
5427c1ca
rspbot
nwidynski
nwidynski commented on 2025-03-17
Conversation is marked as resolved
Show resolved
packages/react-aria-components/src/Select.tsx
65export interface SelectProps<T extends object = {}> extends Omit<AriaSelectProps<T>, 'children' | 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior' | 'items'>, RACValidation, RenderProps<SelectRenderProps>, SlotProps {
66 /**
67 * Temporary text that occupies the select when it is empty.
68
 * @selector [data-placeholder]
nwidynski156 days ago

May be misleading to mention the selector here? From a quick search, I can't find other props where the docs mention the selector even though the value doesn't correlate.

snowystinger155 days ago

ah, copy pasta strikes again, thanks

snowystinger Merge branch 'main' into default-select-placeholder
02229572
snowystinger
snowystinger commented on 2025-03-17
Conversation is marked as resolved
Show resolved
packages/react-aria-components/src/Select.tsx
65export interface SelectProps<T extends object = {}> extends Omit<AriaSelectProps<T>, 'children' | 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior' | 'items'>, RACValidation, RenderProps<SelectRenderProps>, SlotProps {
66 /**
67 * Temporary text that occupies the select when it is empty.
68
 * @selector [data-placeholder]
snowystinger155 days ago
Suggested change
* @selector [data-placeholder]
snowystinger Update packages/react-aria-components/src/Select.tsx
e2ac78f2
rspbot
rspbot
yihuiliao
yihuiliao dismissed these changes on 2025-03-18
snowystinger snowystinger added ready for review
snowystinger snowystinger added small review
LFDanLu
LFDanLu dismissed these changes on 2025-04-11
packages/react-aria-components/src/Select.tsx
65export interface SelectProps<T extends object = {}> extends Omit<AriaSelectProps<T>, 'children' | 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior' | 'items'>, RACValidation, RenderProps<SelectRenderProps>, SlotProps {
66 /**
67 * Temporary text that occupies the select when it is empty.
68
 * @default 'Select an item' in English
LFDanLu131 days ago๐Ÿ‘ 2

Any particular need to mention "in English" here? Is it to point out that localization will happen automatically aka "Select an item" is only when en-US/english locales? I think it should be fine if omitted but not really bothered either way

dannify130 days ago๐Ÿ‘ 1

Maybe "Select an item" (localized) ?

LFDanLu update description
c2faf4ac
LFDanLu LFDanLu dismissed their stale review via c2faf4ac 130 days ago
LFDanLu LFDanLu dismissed their stale review via c2faf4ac 130 days ago
devongovett
devongovett approved these changes on 2025-04-12
LFDanLu
LFDanLu approved these changes on 2025-04-12
LFDanLu LFDanLu enabled auto-merge 130 days ago
devongovett Merge branch 'main' into default-select-placeholder
6c7a89be
rspbot
rspbot
LFDanLu LFDanLu merged 9723225d into main 130 days ago
LFDanLu LFDanLu deleted the default-select-placeholder branch 130 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
small review ready for review
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum