react-spectrum
Clicking the select label focuses on the select element
#860
Merged
Overview
Commits
17
Changes
View On GitHub

Clicking the select label focuses on the select element #860

devongovett merged 17 commits into adobe:main from main
gavinhenderson
gavinhenderson Define a placeholder onPress function
093847a5
gavinhenderson Pass onPress through label
2b38b821
gavinhenderson Fix press event types
8e7b6477
gavinhenderson usePress in useSelect
ae5dfafa
gavinhenderson Pass props through Label
2a44fd34
gavinhenderson Linting fixes
58876bcf
gavinhenderson
snowystinger
snowystinger commented on 2020-07-29
gavinhenderson Simplify label clicking
315943b2
gavinhenderson Linting fixes
fde31723
gavinhenderson Merge branch 'main' of ssh://github.com/adobe/react-spectrum into main
cc96a6b2
gavinhenderson Remove type casting
a9d11ffa
gavinhenderson Put typecast back
acd49fcf
snowystinger Merge branch 'main' into main
5d65ff7d
snowystinger
snowystinger commented on 2020-08-01
gavinhenderson Use isDisabled from the props
b47d2db0
gavinhenderson Merge branch 'main' of ssh://github.com/gavinhenderson/react-spectrum…
c459bf70
gavinhenderson
gavinhenderson Only focus when NOT disabled
b93927a3
gavinhenderson Add test to make sure it focuses when you click the label
5d0e0a91
gavinhenderson Merge branch 'main' of ssh://github.com/adobe/react-spectrum into main
f5142cbc
gavinhenderson gavinhenderson marked this pull request as ready for review 5 years ago
gavinhenderson gavinhenderson requested a review from dannify dannify 5 years ago
LFDanLu
LFDanLu approved these changes on 2020-08-03
snowystinger
snowystinger approved these changes on 2020-08-03
devongovett
devongovett approved these changes on 2020-08-04
devongovett devongovett merged c5b1cf1a into main 5 years ago
devongovett

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum