react-spectrum
fix: add dev warning when dialog has no accessible title
#9819
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
8
Changes
View On
GitHub
fix: add dev warning when dialog has no accessible title
#9819
snowystinger
merged 8 commits into
adobe:main
from
mvanhorn:fix/dialog-title-dev-warning
fix: add dev warning when dialog has no accessible title
d77db9cb
fix(dialog): resolve test failures in dialog title dev warning
25d36d68
snowystinger
commented on 2026-03-20
fix: address review feedback - remove setupTests allowlist entry, dro…
7a62c3b4
fix: add aria-label to test dialogs that lack accessible titles
195a5f74
fix: check props and titleId in addition to DOM attributes for dialog…
910fb848
fix: add aria-label to ContextualHelp dialog and revert ineffective t…
3bd36979
Merge branch 'main' into fix/dialog-title-dev-warning
aa5b959d
fix contextual help usage
6672db92
snowystinger
approved these changes on 2026-03-31
snowystinger
added
ready for review
yihuiliao
approved these changes on 2026-04-01
snowystinger
merged
ac718c6c
into main
2 days ago
Login to write a write a comment.
Login via GitHub
Reviewers
yihuiliao
snowystinger
Assignees
No one assigned
Labels
ready for review
Milestone
No milestone
Login to write a write a comment.
Login via GitHub