PR #986 Create HexColorField component

Bootstrap @react-stately/color package

a8ad6238

Fix lint of plop template

8cd348c1

initial commit

9254c14b

emircado requested a review from

dannify 6 years ago

emircado requested a review from

devongovett 6 years ago

emircado requested a review from

snowystinger 6 years ago

emircado marked this pull request as draft 6 years ago

emircado changed the title ~~Create HexColorField component~~ WIP: Create HexColorField component 6 years ago

initial files for hexcolorfield

da29b534

emircado commented on 2020-08-19

update descriptions

b7744932

added react-types

ad5d806d

emircado commented on 2020-08-20

add stories and test files

138bcde6

starting files for docs site

fc22c18b

emircado commented on 2020-08-21

added color interface

aebccc24

add hooks in aria and stately

64d21e35

emircado commented on 2020-08-25

update aria file names

238c7ff3

start component from numberfield

d9167085

initial work for useHexColorFieldState

876a3c7f

update stately useHexColorFieldState

4c8533b0

don't use optional textValue in stately

f64bd699

emircado commented on 2020-08-28

useHexColorFieldState increment

b768264a

emircado commented on 2020-08-28

add tests for increment

e91a9308

added decrement with tests

f5e28fad

emircado closed this 6 years ago

emircado reopened this 6 years ago

validation for useHexColorFieldState

a2077337

emircado commented on 2020-09-01

test updates

5435a9a6

added tests for increment, decrement

df823321

initialization updates

1217d148

emircado commented on 2020-09-01

test for setColorValue

a48d567d

fix lint errors

5c9c98af

fix more lint errors

102c908e

fix more lint errors

a1d809c4

emircado commented on 2020-09-01

add test for controlled state

02640ea9

updated tests for controlled, uncontrolled

642a53a7

emircado commented on 2020-09-02

added docs for useHexColorFieldState

0a297f24

emircado commented on 2020-09-02

start react-aria useHexColorField

ed1888d2

emircado commented on 2020-09-03

simpler HexColorField component

3f22502b

update aria and spectrum

d101a264

add test for aria useHexColorField

1eb9049a

update react-stately hook

0d9fe6dc

fix lint errors

16d8f466

emircado commented on 2020-09-04

add keyboard events for increment/decrement

d9253305

emircado commented on 2020-09-04

utils for parsing color

1c26d724

emircado commented on 2020-09-04

removed validation logic from useHexColorFieldState

6563e5e7

added story for step

16662ce4

fix lint errors

e579d103

Merge branch 'main' into color

3a1b0306

stately updates

3962d6c1

updated onblur and onchange for useHexColorField

599236d3

added test for commitInputValue

8e8ad180

emircado commented on 2020-09-08

fix lint errors

71eb3520

emircado commented on 2020-09-08

aria + stately updates

a2da5ad3

emircado commented on 2020-09-08

stately updates

4077845b

emircado commented on 2020-09-08

fix test and lint errors

bb0e79a5

undo local jest update

912c18ab

added tests for color

6704d0fd

added aria tests

b5efe161

onchange, onblur tests for aria

3b7699e5

removed docs files

9beb5d43

add back mergeProps again

0a8a1715

move min/max value defaults to stately

99a51789

fix lint errors

77927bbd

added role prop for aria

69b3acca

added story for placeholder

761ff746

stately updates for invalid value props provided

d91c9fe1

comment updates

aafb69f3

no text when no value or default value is provided

2cd3b250

mouse wheel event support

18363c38

story for min/max clamping

fd463453

story as a popover

b1dd9f0b

updated stories and stately

f6aa3dba

updated commitinputvalue

21c6b62f

fix lint errors

581b688a

update useHexColorField interface

09184891

test outline for spectrum component

aa4c79ce

initial tests for react-spectrum

c8749ab0

second set of tests for react-spectrum

5b387b73

third batch of tests for react-spectrum

e707aaa7

fourth set of tests for react-spectrum

95773016

emircado marked this pull request as ready for review 6 years ago

emircado changed the title ~~WIP: Create HexColorField component~~ Create HexColorField component 6 years ago

snowystinger commented on 2020-09-16

snowystinger commented on 2020-09-17

remove screen from, add act to react-spectrum tests

3ab01e61

use Omit for HexColorFieldState

e366835d

emircado changed the title ~~Create HexColorField component~~ WIP: Create HexColorField component 6 years ago

new ref for every test in useHexColorField

d1621943

updates for defaults test in HexColorField

d3600d2f

added tests for controlled in accepted values

e4377eb5

updated HexColorField tests with keyUp + keyDown pairs

f93e341c

updated HexColorField test for placeholder

4332d60a

added onChange assertions in HexColorField

7d3e325f

fixed lint warnings

f62db0df

Merge branch 'main' into color

f087b6d6

Merge remote-tracking branch 'upstream/color' into hexcolorfield

566a0964

remove eslint-disable in useHexColorField

6b898c6a

fix lint error, warning

1a69849d

fixed test error

fe640cf7

used typeText for HexColorField tests

d31f8c6d

added story for controlled value

64d6c917

use let

f40d2560

fix lint error, update controlled story

6ff39e87

merge entire spinbutton props

9a816f67

fix lint error

bf6a5f05

more lint fixes

75ebe0da

add useColor hook

a17d5e38

initial refactor to use useColor

4e32336a

useColor for useHexColorField and HexColorField stories

16d55266

update increment, decrement for unnecessary onchange calls

c5375e8c

HexColorField test updates for increment, decrement changes

43492810

updates to incrementToMax, decrementToMin for onChange calls

905b046b

should not trigger onchange when color value is the same

22099bfb

fix lint errors

db5a28ea

minor, rename variables

a8847b19

added onChangeSpy checks after onBlur

546d6399

fix lint error

4c92ef91

more generic clamp

d19a051a

clamp updates

db395a6e

clamp min and max values

c167ba12

tests for clamp min and max

a8ccd7da

fix lint error

520f1e72

valid hex characters only

8af2a664

lint error

8765530f

fixe for incrementToMax, decrementToMin

4e15412d

fixes for decrement

d3a4a6c4

emircado changed the title ~~WIP: Create HexColorField component~~ Create HexColorField component 6 years ago

snowystinger commented on 2020-09-28

emircado commented on 2020-09-29

add comment for disabled lines

c24da28c

update test to use hex number instead of int

9b0ce5eb

useCallback for increment, decrement

ecb47c4b

emircado changed the title ~~Create HexColorField component~~ WIP: Create HexColorField component 6 years ago

storybook fix

d0669618

emircado commented on 2020-09-29

fix lint error

db5b0f50

wrap userEvent in act

dde3e455

use already calculated string for setInputValue in increment, decrement

d300ad93

dannify closed this 6 years ago

devongovett reopened this 6 years ago

devongovett changed the base branch from color to main 6 years ago

Merge remote-tracking branch 'upstream/main' into hexcolorfield

d59c63ae

forgot to save merge conflict fixes

cc3d6c1b

change Color.toHexInt to hex number format

e500ee2d

initial refactor for removing min/max props

844c594f

useHexColorFieldState test updates for removing min/max props

c0775f6a

added test for useColor

9990e396

test update for useHexColorField

2f6e665f

test updates for HexColorField, with min/max props removed

273eb93c

clear colorValue when input is cleared

8b4865db

test updates for new onChange behavior

3855c637

Merge remote-tracking branch 'upstream/main' into hexcolorfield

6bb957e6

emircado changed the title ~~WIP: Create HexColorField component~~ Create HexColorField component 6 years ago

snowystinger commented on 2020-10-02

emircado commented on 2020-10-02

fix for controlled story

c55db384

do not import min and maxColor in test

06a1da8c

rename minColor and maxColor to MIN_COLOR and MAX_COLOR

7c69fc53

remove tests for PageUp, PageDown keys

4b3d3ce4

update toHexInt

b37a1012

Merge branch 'main' into hexcolorfield

852ad38f

snowystinger commented on 2020-10-05

use constants for Math.pow

02d973a9

Merge branch 'main' into hexcolorfield

851d5330

emircado requested a review from

snowystinger 6 years ago

snowystinger dismissed these changes on 2020-10-06

majornista commented on 2020-10-06

LFDanLu requested changes on 2020-10-13

Merge remote-tracking branch 'upstream/main' into hexcolorfield

259698cc

emircado dismissed their stale review via 259698cc 6 years ago

Apply suggestions from code review

8fe12605

more resolve merge conflicts

8725ae6f

Merge branch 'hexcolorfield' of https://github.com/emircado/react-spe…

412ad14c

update test for scroll

74169bd9

emircado requested a review from

LFDanLu 6 years ago

emircado requested a review from

snowystinger 6 years ago

use onWheel prop for wheel events

3627df7f

LFDanLu dismissed these changes on 2020-10-19

devongovett commented on 2020-10-03

don't export constants; don't use useCallback

197e571c

emircado dismissed their stale review via 197e571c 6 years ago

added autoCorrect

1a1c3f85

use bitwise operators

0fcd04c9

update useColor

2b5d60a1

Merge branch 'main' into hexcolorfield

45fdaad1

update regex for input

fa278a50

increment, decrement logic in one function

9de9e9d2

Merge branch 'main' into hexcolorfield

5112d213

update for addColorValue

39e6ccc5

useEffect on stately

1f3a1bbb

stately update

64f746f2

Merge branch 'main' into hexcolorfield

7332fcc4

emircado requested a review from

devongovett 6 years ago

stately update

a95b7bf9

fix for setState warning + tests

813dcf59

Merge branch 'main' into hexcolorfield

37748707

Merge branch 'main' into hexcolorfield

ddb79dfd

Merge branch 'main' into hexcolorfield

598ca7c3

devongovett dismissed these changes on 2020-10-29

Merge branch 'main' into hexcolorfield

01d42c0d

dannify dismissed their stale review via 01d42c0d 6 years ago

dannify approved these changes on 2020-10-30

dannify merged 879cbbdd into main 6 years ago

emircado deleted the hexcolorfield branch 5 years ago

react-spectrum
Create HexColorField component
#986

Merged

Create HexColorField component #986

react-spectrum Create HexColorField component #986 Merged

Create HexColorField component #986

react-spectrum
Create HexColorField component
#986

Merged