react-spectrum
feat: add highlight selection to S2 TableView
#9883
Merged
Overview
Commits
49
Changes
View On GitHub

feat: add highlight selection to S2 TableView #9883

LFDanLu merged 49 commits into main from design-prototype
yihuiliao
yihuiliao add selectionStyle prop
3b4b145e
yihuiliao current state of highlight which sorta works but idk if i like the im…
9adcfb26
yihuiliao fix lint
6a79fa6d
yihuiliao Merge branch 'main' into highlight-selection-tableview
e38fa30a
yihuiliao Merge branch 'main' into highlight-selection-tableview
7ae2ed29
yihuiliao code cleanup + comments
e59fe39e
yihuiliao fix lint
0cb910e1
yihuiliao add highlight selection to the docs
33cbc66c
yihuiliao add jsdoc comment
8646952b
yihuiliao update hcm
042ce49c
yihuiliao add chromatic stories
a31ba79d
yihuiliao Merge branch 'main' into highlight-selection-tableview
54cf8ad1
yihuiliao add ids to table with links to fix styles
d7be568f
yihuiliao minor cleanup
8a2ea101
yihuiliao Merge branch 'main' into highlight-selection-tableview
8f98eef2
yihuiliao fix import
76da66fa
yihuiliao Merge branch 'main' into highlight-selection-tableview
c0a87526
yihuiliao prototype different version of highlight selection
13ee5188
yihuiliao yihuiliao marked this pull request as draft 100 days ago
github-actions github-actions added RAC
github-actions github-actions added S2
yihuiliao yihuiliao changed the base branch from main to highlight-selection-tableview 100 days ago
yihuiliao yihuiliao changed the base branch from highlight-selection-tableview to main 100 days ago
yihuiliao yihuiliao changed the base branch from main to highlight-selection-tableview 100 days ago
rspbot
yihuiliao yihuiliao changed the base branch from highlight-selection-tableview to main 100 days ago
yihuiliao add a comment with my new brilliant idea so i don't forget
a12ae635
yihuiliao Merge branch 'main' into design-prototype
dd136742
yihuiliao fix rounded borders, focus ring
83a37a56
rspbot
yihuiliao Merge branch 'main' into design-prototype
489ef006
yihuiliao yihuiliao changed the title dnm: prototype different highlight selection design for TableView feat: add highlight selection to S2 TableView 83 days ago
yihuiliao support gray dividers between rows
896f6ba5
rspbot
yihuiliao use borders (mainly) for highlight selection over box shadow
24bf07ac
yihuiliao Merge branch 'main' into design-prototype
f186db5e
rspbot
rspbot
yihuiliao fix hcm to match v3 and cleanup
4b0b5dc3
rspbot
yihuiliao
yihuiliao commented on 2026-05-07
yihuiliao yihuiliao marked this pull request as ready for review 70 days ago
yihuiliao yihuiliao added release
yihuiliao yihuiliao added ready for review
snowystinger snowystinger requested a review from copilot-pull-request-reviewer copilot-pull-request-reviewer 70 days ago
copilot-pull-request-reviewer
copilot-pull-request-reviewer commented on 2026-05-07
yihuiliao thanks copilot
88665232
rspbot
yihuiliao cleanup
5b37c63e
yihuiliao Merge branch 'main' into design-prototype
3a4c7aac
yihuiliao
rspbot
LFDanLu
LFDanLu commented on 2026-05-08
yihuiliao Merge branch 'main' into design-prototype
aa9833ff
yihuiliao format
7508ef72
yihuiliao more formatting
7acee0d3
yihuiliao fix ts error
caa89423
github-actions github-actions added TableView
github-actions github-actions added TreeView
github-actions github-actions added Table
yihuiliao yihuiliao added test off PR
yihuiliao yihuiliao removed RAC
rspbot
snowystinger
snowystinger commented on 2026-05-12
yihuiliao hcm fixes
c66bf9b0
yihuiliao adjust z index
09ca445d
yihuiliao cleanup cell styles
f5327709
yihuiliao update utils
a5a30237
yihuiliao format
e758d36e
github-actions github-actions added RAC
yihuiliao
yihuiliao commented on 2026-05-12
rspbot
yihuiliao Merge branch 'main' into design-prototype
bfcbbd6d
yihuiliao format
2487380a
rspbot
yihuiliao
reidbarber
reidbarber commented on 2026-05-15
LFDanLu
LFDanLu dismissed these changes on 2026-05-15
yihuiliao address review comments
25683b20
yihuiliao yihuiliao dismissed their stale review via 25683b20 62 days ago
yihuiliao fix formatting
0f226422
yihuiliao fix lint
5d04f428
rspbot
LFDanLu
LFDanLu dismissed these changes on 2026-05-15
devongovett
devongovett dismissed these changes on 2026-05-16
snowystinger
snowystinger dismissed these changes on 2026-05-18
yihuiliao Merge branch 'main' into design-prototype
c4d747cc
yihuiliao fix
7ec644b3
yihuiliao fix dnd with highlight selection
ca13c537
yihuiliao yihuiliao dismissed their stale review via ca13c537 59 days ago
yihuiliao yihuiliao dismissed their stale review via ca13c537 59 days ago
yihuiliao yihuiliao dismissed their stale review via ca13c537 59 days ago
yihuiliao fix lint
dd8c7b24
yihuiliao fix typecheck
5bbbb47c
yihuiliao formating....
dc6b6499
rspbot
rspbot
rspbot
devongovett
devongovett approved these changes on 2026-05-18
LFDanLu
LFDanLu approved these changes on 2026-05-18
LFDanLu LFDanLu merged 2acd4438 into main 59 days ago
LFDanLu LFDanLu deleted the design-prototype branch 59 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
TableView TreeView release ready for review RAC S2 Table test off PR
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum