react-spectrum
fix(dialog): add aria-describedby support for alertdialog role
#9924
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
21
Changes
View On
GitHub
fix(dialog): add aria-describedby support for alertdialog role
#9924
snowystinger
merged 21 commits into
adobe:main
from
costajohnt:fix/alert-dialog-aria-describedby
github-actions
added
RAC
costajohnt
force pushed
from
2f3f4216
to
3798d489
72 days ago
yihuiliao
commented on 2026-04-15
fix(dialog): add aria-describedby support for alertdialog role
6556634d
fix: wire contentProps via TextContext for RAC alertdialog aria-descr…
afbfd15f
test: add RAC integration test for alertdialog aria-describedby via T…
eec13abd
fix: sort TextContext import alphabetically in RAC Dialog
368799e4
costajohnt
force pushed
from
3798d489
to
368799e4
71 days ago
update tests, add warning to RAC
cf8cdb00
add describedby to s2 alert dialog
44089617
github-actions
added
S2
fix test
27089261
Merge branch 'main' into fix/alert-dialog-aria-describedby
4348b5b7
refactor, add tests, fix image labels in examples
a3b9ee8c
fix lint
91fae1df
snowystinger
commented on 2026-04-23
fix: allow aria-describedby override in v3 AlertDialog
47b03f1b
fix(useDialog): drop contentId when aria-describedby is user-provided
65198922
fix(s2): wire aria-describedby on S2 AlertDialog via explicit contentId
7dd35ab7
fix(s2): import useId from react-aria/useId, not 'react'
c52579c5
github-actions
added
Dialog
Merge branch 'main' into fix/alert-dialog-aria-describedby
bc95df2f
fix some merge changes
0e51eec7
move warning down to hook and remove extra code from s2
74678a47
snowystinger
dismissed these changes on 2026-05-11
Merge remote-tracking branch 'upstream/main' into fix/alert-dialog-ar…
366e9bae
costajohnt
dismissed their stale review via
366e9bae
18 days ago
test: use renamed DialogTester.getDialog() API after merge
ea9f7b0e
snowystinger
dismissed these changes on 2026-06-09
snowystinger
added
ready for review
Merge branch 'main' into fix/alert-dialog-aria-describedby
8988363c
make more forgiving since spec says "should"
75a8640b
snowystinger
dismissed their stale review via
75a8640b
5 hours ago
devongovett
approved these changes on 2026-06-25
snowystinger
approved these changes on 2026-06-25
snowystinger
merged
ba923ddf
into main
4 hours ago
Login to write a write a comment.
Login via GitHub
Reviewers
snowystinger
devongovett
yihuiliao
LFDanLu
Assignees
No one assigned
Labels
ready for review
RAC
S2
Dialog
Milestone
No milestone
Login to write a write a comment.
Login via GitHub