react-spectrum
fix(dialog): add aria-describedby support for alertdialog role
#9924
Merged

fix(dialog): add aria-describedby support for alertdialog role #9924

costajohnt
github-actions github-actions added RAC
costajohnt costajohnt force pushed from 2f3f4216 to 3798d489 72 days ago
yihuiliao
yihuiliao commented on 2026-04-15
costajohnt fix(dialog): add aria-describedby support for alertdialog role
6556634d
costajohnt fix: wire contentProps via TextContext for RAC alertdialog aria-descr…
afbfd15f
costajohnt test: add RAC integration test for alertdialog aria-describedby via T…
eec13abd
costajohnt fix: sort TextContext import alphabetically in RAC Dialog
368799e4
costajohnt costajohnt force pushed from 3798d489 to 368799e4 71 days ago
yihuiliao update tests, add warning to RAC
cf8cdb00
yihuiliao add describedby to s2 alert dialog
44089617
github-actions github-actions added S2
yihuiliao fix test
27089261
yihuiliao Merge branch 'main' into fix/alert-dialog-aria-describedby
4348b5b7
snowystinger refactor, add tests, fix image labels in examples
a3b9ee8c
snowystinger fix lint
91fae1df
snowystinger
snowystinger commented on 2026-04-23
costajohnt fix: allow aria-describedby override in v3 AlertDialog
47b03f1b
costajohnt fix(useDialog): drop contentId when aria-describedby is user-provided
65198922
costajohnt fix(s2): wire aria-describedby on S2 AlertDialog via explicit contentId
7dd35ab7
costajohnt fix(s2): import useId from react-aria/useId, not 'react'
c52579c5
github-actions github-actions added Dialog
costajohnt
snowystinger Merge branch 'main' into fix/alert-dialog-aria-describedby
bc95df2f
snowystinger fix some merge changes
0e51eec7
snowystinger move warning down to hook and remove extra code from s2
74678a47
snowystinger
snowystinger dismissed these changes on 2026-05-11
costajohnt Merge remote-tracking branch 'upstream/main' into fix/alert-dialog-ar…
366e9bae
costajohnt costajohnt dismissed their stale review via 366e9bae 18 days ago
costajohnt test: use renamed DialogTester.getDialog() API after merge
ea9f7b0e
snowystinger
snowystinger dismissed these changes on 2026-06-09
snowystinger snowystinger added ready for review
snowystinger Merge branch 'main' into fix/alert-dialog-aria-describedby
8988363c
snowystinger make more forgiving since spec says "should"
75a8640b
snowystinger snowystinger dismissed their stale review via 75a8640b 5 hours ago
devongovett
devongovett approved these changes on 2026-06-25
snowystinger
snowystinger approved these changes on 2026-06-25
snowystinger snowystinger merged ba923ddf into main 4 hours ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone