Disallow SORT BY in SQL #5249
Disallow SORT BY in SQL
| 59 | 59 | if select.top.is_some() { | |
| 60 | 60 | return Err(DataFusionError::NotImplemented("TOP".to_string())); | |
| 61 | 61 | } | |
| 62 | if !select.sort_by.is_empty() { |
alamb2 years ago👍
It would be nice to add a .slt test for this case, but I also think it is ok not to
Here is a proposed test: #5254
Benchmark runs are scheduled for baseline = 8719041 and contender = ec9119d. ec9119d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
Login to write a write a comment.
Which issue does this PR close?
Closes #5247
Rationale for this change
What changes are included in this PR?
Are these changes tested?
No tests added. Adding tests for invalid SQL might not be desirable (considering potential surface area of invalid SQL)
Are there any user-facing changes?