drill
DRILL-6956: Maintain a single entry for Drill Version in the pom file
#1605
Open
Open
DRILL-6956: Maintain a single entry for Drill Version in the pom file #1605
kkhatua
wants to merge
1 commit into
apache:master
from
kkhatua:DRILL-6956
vdiravka6 years ago (edited 6 years ago)
@kkhatua This is a good change, but there are two concerns with it:
- according to maven doc this feature works starting from 3.5.0-beta-1 Maven version. It means that we push all devs to update their Maven to 3.5.0 version. Currently Drill can be built with Maven 3.3.3 version. Do we really want it? Possibly it can be discussed on mailing list.
- Did you verify
mvn release:preparemaven phase? Did it update version entry only in a single place?
vdiravka
requested changes
on 2019-04-24
vdiravka6 years ago (edited 6 years ago)
@kkhatua
Looks like it is not full setup. flatten-maven-plugin should be added to replace ${revision} placeholders after generating artifacts.
Please check Install / Deploy section of https://maven.apache.org/maven-ci-friendly.html
DRILL-6956: Maintain a single entry for Drill Version in the pom file
468936c2
Login to write a write a comment.
Currently, updating the version information for a Drill release involves updating 30+ pom files.
The right way would be to use the Multi Module Setup for Maven CI.
https://maven.apache.org/maven-ci-friendly.html#Multi_Module_Setup