DRILL-7169: Rename drill-root ArtifactID to apache-drill #1746
@vdiravka, with this change, a folder with the unpacked build in distribution was renamed from apache-drill-1.16.0-SNAPSHOT to distribution-1.16.0-SNAPSHOT, so for now built version is in the distribution/target/distribution-1.16.0-SNAPSHOT/distribution-1.16.0-SNAPSHOT/ instead of distribution/target/apache-drill-1.16.0-SNAPSHOT/apache-drill-1.16.0-SNAPSHOT/.
I don't think that we should rename these folders.
@vdiravka, with this change, a folder with the unpacked build in distribution was renamed from
apache-drill-1.16.0-SNAPSHOTtodistribution-1.16.0-SNAPSHOT, so for now built version is in thedistribution/target/distribution-1.16.0-SNAPSHOT/distribution-1.16.0-SNAPSHOT/instead ofdistribution/target/apache-drill-1.16.0-SNAPSHOT/apache-drill-1.16.0-SNAPSHOT/.I don't think that we should rename these folders.
Thanks for finding this, it is random mistake.
| 391 | 391 | <sources> | |
| 392 | 392 | <source> | |
| 393 | <location>target/apache-drill-${project.version}/apache-drill-${project.version}/git.properties</location> | ||
| 393 | <location>target/${project.parent.artifactId}-${project.version}/${project.parent.artifactId}-${project.version}/git.properties</location> |
sohami6 years agoall the <location>target/... can be replaced by <location>${project.build.directory}/....
vdiravka6 years agoGood suggestion. Done.
| 44 | 44 | ||
| 45 | <target.gen.source.path>${project.basedir}/target/generated-sources</target.gen.source.path> | ||
| 45 | <target.gen.source.path>${project.build.directory}/generated-sources</target.gen.source.path> | ||
| 46 | 46 | <proto.cas.path>${project.basedir}/src/main/protobuf/</proto.cas.path> |
sohami6 years agois this path correct ? I don't see any src/main/protobuf path ?
Also there are other places like line 549 which can be modified to replace target/classes with ${project.build.outputDirectory}
vdiravka6 years ago-
Looks like it was introduced for a long time ago for
maven-antrun-plugin.
b53933f#diff-0c2b5a9caaab6aa53c1c6c7dead7be77R118
But a little bit later this usage was removed. I think it is safe to remove it. -
Modified
+1
Changes look good, but as we discussed before, it would be good to hear community opinion about this change.
Please send a letter to the dev and user mailing lists about this change.
+1
DRILL-7169: Rename drill-root ArtifactID to apache-drill
Fix mistake
Replace all 'target/', 'target/classes' and 'target/test-classes' pat…
Fix POM headers alignment
@vvysotskyi @sohami I have rebased the changes onto latest Drill master branch and added one commit with minor improvement.
Please review it, once the community will agreed in dev mailing list with these changes:
Note: mail topic is Rename 'project.artifactId'
@vdiravka / @vvysotskyi what is the status of this PR?
Currently, there is no consensus for this change, here is mail thread with the discussion: https://lists.apache.org/thread.html/99a2098ae04d56dd5994288b5fc05780d7de09a2f4a5ffbc5ce39cde@%3Cdev.drill.apache.org%3E
Login to write a write a comment.
Change 'project.artifactId' from 'drill-root' to 'apache-drill'
Note: it includes changes for #1743 also (it is expected that PR will be merged first)