DRILL-8136: Overhaul implict type casting logic #2638
jnturton
merged
26 commits into
apache:master
from
jnturton:implicit-cast-graph
cgivre
changed the title
jnturton
changed the title
Fix the comment on the MONEY minor type protobuf definition.
6b88762a
Use a weighted graph to calculate implicit casting costs.
ee87bb15
Remove old precedence map cruft.
7d3b061d
Add a comment on casting costs.
9566aa8b
WIP
2cb93953
Adjust casting rules.
2059d3e2
Remove PRECISION_LOSS_CAST edge weight.
5a094c9e
Adjust casting graph weights and add some SQL tests.
9ff08cd3
Add BIT to VARCHAR's conversions.
ade00d8e
Add and test VARCHAR - BIT casting.
c525a1c5
Remove UNSUPPORTED_TYPES from ResolverTypePrecedence, adjust edge wei…
62a65c88
Make INT the nearest type to VARCHAR.
5ebbcb90
Remove BASE_COST constant.
19915056
Prefer to cast INT to VARDECIMAL than vice versa.
ee15fd5f
Adjust edge weights.
99a46e69
Prefer to cast INTs to VARDECIMALs over VARDECIMALs to FLOATs.
07663842
Remove edge from FLOAT to VARDECIMAL.
0e971888
Complete numeric parameter type support in isnumeric, link FLOAT to V…
2de2533f
Add edge from VARBINARY TO VARCHAR.
f5ad5624
Base return type logic in TypeInferenceUtils on cheapest cast.
44711e4d
Fix casting cost test and checkstyle.
cec32ef6
Raise an error when function matching is ambiguous.
b215fcc1
Add LATE type to ResolverTypePrecedence and a cost disambiguate varar…
ceb86094
Make FLOAT8 cheaper than FLOAT4 for VARCHAR and VARDECIMAL.
14993693
Always prefer to cast NULL to non-NULL.
726366b6
Fix VARCHAR to TIMESTAMP cost and add casting preference test.
5bb37afa
vvysotskyi
approved these changes
on 2022-09-19
Login to write a write a comment.
Login via GitHub