drill
DRILL-8136: Overhaul implict type casting logic
#2638
Merged
Overview
Commits
26
Changes
View On GitHub

DRILL-8136: Overhaul implict type casting logic #2638

jnturton merged 26 commits into apache:master from jnturton:implicit-cast-graph
jnturton
jnturton jnturton added enhancement
jnturton jnturton added udf
jnturton jnturton marked this pull request as draft 2 years ago
cgivre cgivre assigned jnturton jnturton 2 years ago
cgivre cgivre changed the title DRILL-8136: Overhaul implict type casting logic DRILL-8136: Overhaul Implict Type Casting Logic 2 years ago
cgivre
cgivre
jnturton
jnturton
jnturton jnturton force pushed from df009e69 to 0ed7ad32 2 years ago
cgivre
jnturton
cgivre
jnturton jnturton marked this pull request as ready for review 2 years ago
jnturton jnturton changed the title DRILL-8136: Overhaul Implict Type Casting Logic DRILL-8136: Overhaul implict type casting logic 2 years ago
jnturton
cgivre
cgivre
cgivre cgivre added doc-impacting
jnturton
jnturton
jnturton
jnturton jnturton force pushed from 47f5a99f to a719d634 2 years ago
jnturton
cgivre
jnturton jnturton removed udf
jnturton
jnturton jnturton force pushed from eb9a9847 to b53abde7 2 years ago
jnturton jnturton force pushed from 1a51a42d to b03b9c0c 2 years ago
jnturton jnturton force pushed from 28a1ca70 to ae6c6b80 2 years ago
jnturton
jnturton jnturton requested a review from vvysotskyi vvysotskyi 2 years ago
vvysotskyi
vvysotskyi commented on 2022-09-14
jnturton jnturton requested a review from vvysotskyi vvysotskyi 2 years ago
jnturton Fix the comment on the MONEY minor type protobuf definition.
6b88762a
jnturton Use a weighted graph to calculate implicit casting costs.
ee87bb15
jnturton Remove old precedence map cruft.
7d3b061d
jnturton Add a comment on casting costs.
9566aa8b
jnturton WIP
2cb93953
jnturton Adjust casting rules.
2059d3e2
jnturton Remove PRECISION_LOSS_CAST edge weight.
5a094c9e
jnturton Adjust casting graph weights and add some SQL tests.
9ff08cd3
jnturton Add BIT to VARCHAR's conversions.
ade00d8e
jnturton Add and test VARCHAR - BIT casting.
c525a1c5
jnturton Remove UNSUPPORTED_TYPES from ResolverTypePrecedence, adjust edge wei…
62a65c88
jnturton Make INT the nearest type to VARCHAR.
5ebbcb90
jnturton Remove BASE_COST constant.
19915056
jnturton Prefer to cast INT to VARDECIMAL than vice versa.
ee15fd5f
jnturton Adjust edge weights.
99a46e69
jnturton Prefer to cast INTs to VARDECIMALs over VARDECIMALs to FLOATs.
07663842
jnturton Remove edge from FLOAT to VARDECIMAL.
0e971888
jnturton Complete numeric parameter type support in isnumeric, link FLOAT to V…
2de2533f
jnturton Add edge from VARBINARY TO VARCHAR.
f5ad5624
jnturton Base return type logic in TypeInferenceUtils on cheapest cast.
44711e4d
jnturton Fix casting cost test and checkstyle.
cec32ef6
jnturton Raise an error when function matching is ambiguous.
b215fcc1
jnturton Add LATE type to ResolverTypePrecedence and a cost disambiguate varar…
ceb86094
jnturton Make FLOAT8 cheaper than FLOAT4 for VARCHAR and VARDECIMAL.
14993693
jnturton Always prefer to cast NULL to non-NULL.
726366b6
jnturton jnturton force pushed from de0cf1ca to 726366b6 2 years ago
jnturton Fix VARCHAR to TIMESTAMP cost and add casting preference test.
5bb37afa
vvysotskyi
vvysotskyi approved these changes on 2022-09-19
jnturton jnturton merged ab7f9e99 into master 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
Labels
enhancement doc-impacting
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum