drill
DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader
#2657

Open

DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader #2657

cgivre wants to merge 9 commits into apache:master from cgivre:druid_evf

cgivre2 years ago (edited 314 days ago)

DRILL-8316: Convert Druid Storage Plugin to EVF & V2 JSON Reader

Description

Converts the Druid storage plugin to use the V2 JSON reader. Also, updates the docker to test this plugin with the latest version of Druid.

Documentation

No user facing changes.

Testing

Ran existing unit tests.

cgivre assigned

cgivre 2 years ago

cgivre added code-cleanup

cgivre added refactoring

cgivre added json

cgivre force pushed from ae675110 to 50c8b6e1 2 years ago

cgivre force pushed from 145fa57a to f31f633a 2 years ago

cgivre force pushed from f31f633a to 337391a9 2 years ago

cgivre force pushed from 337391a9 to 6cc9e3f5 2 years ago

cgivre marked this pull request as ready for review 2 years ago

cgivre2 years ago

@Z0ltrix Would you mind reviewing this? The unit tests pass, but I'm not 100% certain this is handling large data sets correctly.

cgivre force pushed from 722a9dc8 to ab311e27 2 years ago

cgivre force pushed from ab311e27 to a9f5e565 1 year ago

Initial Work

05160045

WIP

9fe0186e

Almost working

e17b6422

Removed unused imports

7b3ad77f

Added offset tracker

6d695488

Working?

1805c9e6

WIP

f4a9cd28

cgivre force pushed from a9f5e565 to f4a9cd28 315 days ago

Fixed unit tests

65227511

Tested with latest version of Druid

818c9787

cgivre requested a review from

jnturton 314 days ago

cgivre314 days ago

@jnturton
Could you do a review of this. I realized that this has been languishing and we might as well merge it if it can be.
The one area which I'm a little hesitant about is the ScanBatchCreator. Basically, since I didn't write this storage plugin and it was a bit more complicated than some of the ones I've written, I'd like another set of eyes on it.

Reviewers

jnturton

Assignees

cgivre

Labels

code-cleanup refactoring json

Milestone

No milestone