PR #2959 Fix DateFormat in DateGen.java

Fix DateFormat in DateGen.java #2959

cgivre merged 2 commits into master from pjfanning-patch-2

pjfanning211 days ago (edited 73 days ago)

See #2958

Fix DateFormat in DateGen.java

99bbde8c

pjfanning commented on 2024-10-26

exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/DateGen.java

49	49
50	50	@Override
51	51	public void setValue() {
52		long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;
53		String str = fmt.format(new Date(randTime));
54		colWriter.setString(str);
	52	final long randTime = baseTime + baseTime + rand.nextInt(365) * ONE_DAY;

pjfanning211 days ago

@jnturton @cgivre this doesn't look right - baseTime is a big number but we add it twice so the result will be a very big number, a long way in the future.

cgivre74 days ago

@pjfanning What if you just make it:

long randTime = baseTime + (rand.nextInt(365)* ONE_DAY)

pjfanning marked this pull request as draft 211 days ago

cgivre assigned

pjfanning 74 days ago

cgivre requested changes on 2025-03-12

Update DateGen.java

df80c1e1

pjfanning changed the title ~~[DRAFT] Fix DateFormat in DateGen.java~~ Fix DateFormat in DateGen.java 73 days ago

pjfanning marked this pull request as ready for review 73 days ago

pjfanning73 days ago

@cgivre I made the change to the randTime calculation

cgivre approved these changes on 2025-03-13

cgivre73 days ago

LGTM +1

cgivre merged d5358d64 into master 73 days ago

Reviewers

cgivre

Assignees

pjfanning

Labels

None yet

Milestone

No milestone

drill Fix DateFormat in DateGen.java #2959 Merged

Fix DateFormat in DateGen.java #2959

drill
Fix DateFormat in DateGen.java
#2959

Merged