keybr.com
feat: Move the 'Caps lock is on' dialog below the text
#370
Merged

feat: Move the 'Caps lock is on' dialog below the text #370

aradzie merged 1 commit into aradzie:master from Merwin4:caps-lock-ui-fix
Merwin4
Merwin4123 days ago

Summary

This pull request addresses Issue #343, where the "Caps Lock is on" dialogue occludes the text being typed, potentially disrupting the user experience. The updated solution ensures that users can focus on the text even if Caps Lock is accidentally engaged.

Changes Made

  • Moved the "Caps Lock is on" dialogue below the text input area.
  • Adjusted the layout so the text lines box expands dynamically, ensuring the keyboard SVG shifts down without overlapping critical UI elements.
  • Maintains user focus by drawing attention to Caps Lock status without blocking the text.

Screenshots

Before:
Before

After:
After

Benefits

  • The new placement ensures the dialogue is noticeable while preserving text visibility.
  • A non-intrusive design improves the user experience by avoiding overlap with the text input area.

Feedback

This is my first contribution to an open-source project! I'm open to suggestions or alternative ideas for improving this solution. Looking forward to your feedback.

feat: Move the 'Caps lock is on' dialog below the text
fce537e2
semanticdiff-com
semanticdiff-com123 days ago (edited 123 days ago)

Review changes with  SemanticDiff

Changed Files
File Status
  packages/keybr-textinput-ui/lib/TextArea.module.less Unsupported file format
  packages/keybr-textinput-ui/lib/TextArea.tsx  0% smaller
aradzie aradzie merged 6553f6d3 into master 110 days ago
aradzie
aradzie110 days ago

Thanks for your contribution!
I have updated the website with your changes.
An I am sorry it took me two weeks to review and merge your PR. I needed to take a break to accumulate more energy to continue to work on this project. I hope to add more features in the near future.

Login to write a write a comment.

Login via GitHub

Reviewers
No reviews
Assignees
No one assigned
Labels
Milestone