Regenerate en_hands_down_promethium.ts #419
aradzie
merged
1 commit into
aradzie:master
from
peterjc:patch-1
Regenerate en_hands_down_promethium.ts
d921157d
semanticdiff-com42 days ago (edited 42 days ago)
Review changes with
Changed Files
| File | Status |
|---|---|
 packages/keybr-keyboard/lib/layout/en_hands_down_promethium.ts |
 42% smaller |
peterjc42 days ago
It looks to me like #385 may have added ThumbClusterLeft1 and ThumbClusterRight1 to the generated file manually - i.e. the generating script doesn't yet cover letters on thumbs?
aradzie42 days ago👍 1
Thanks!
I tried this PR on a local copy, the keys did not show up.
It seems like it needs a bit more work.
Please give me a day to fix the remaining issues.
And I am sorry for the delayed responses and reviews.
peterjc42 days ago
Thanks - I wasn't able to test it locally due to #420
Login to write a write a comment.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Ran
npm run generate-layoutsas per https://github.com/aradzie/keybr.com/blob/master/docs/custom_keyboard.md to pickup the changes in #401 aiming to close #400.I then manually restored these two lines which were otherwise lost (perhaps an issue with the generator script?):