ruff
F401 - Distinguish between imports we wish to remove and those we wish to make explicit-exports
#11168
Merged

F401 - Distinguish between imports we wish to remove and those we wish to make explicit-exports #11168

plredmond merged 36 commits into main from ruff.F401
plredmond
plredmond plredmond force pushed from de31d897 to d9d863eb 1 year ago
plredmond plredmond force pushed from d9d863eb to 0baf16e4 1 year ago
plredmond plredmond marked this pull request as ready for review 1 year ago
plredmond
plredmond commented on 2024-04-29
plredmond
plredmond commented on 2024-04-29
plredmond
plredmond commented on 2024-04-29
github-actions
zanieb
zanieb commented on 2024-04-29
zanieb
plredmond
zanieb zanieb requested a review from MichaReiser MichaReiser 1 year ago
plredmond [ruff F401 #10390 #10391] categorize imports that this rule will appl…
e8ccbc13
plredmond [ruff F401 #10390 #10391] add import category to ImportBinding struct
c3cb1fc0
plredmond [ruff F401 #10390 #10391] edit to make imports explicit
2555105a
plredmond [ruff F401 #10390 #10391] narrower categories
66d92495
plredmond [ruff F401 #10390 #10391] note some renames that would help with read…
2990bb6c
plredmond [ruff F401 #10390 #10391] split import bindings by fix we wish to apply
9b70c3b8
plredmond [ruff F401 #10390 #10391] tweak "fix_imports"; rename it and only ret…
0d52dc71
plredmond [ruff F401 #10390 #10391] another "fix_imports" function but this one…
55c4906e
plredmond [ruff F401 #10390 #10391] generate two fixes (instead of one) for the…
80bbdd44
plredmond [ruff F401 #10390 #10391] remove categorize
a35ca67b
plredmond [ruff F401 #10390 #10391] rename/remove/cleanup
f29708f7
plredmond [ruff F401 #10390 #10391] rename and adjust new "fix_imports" function
a8f5373d
plredmond [ruff F401 #10390 #10391] cleanup the other fix-imports function
d666bac5
plredmond [ruff F401 #10390 #10391] add fixture tests for F401 w/__init__.py; r…
c05285f3
plredmond [ruff F401 #10390 #10391] clippy
f2867641
plredmond [ruff F401 #10390 #10391] move comment about tests
203bf015
plredmond [ruff F401 #10390 #10391] unit tests for make_redundant_alias
bd22137b
plredmond plredmond force pushed from 315e10be to c45124db 1 year ago
plredmond [ruff F401 #10390 #10391] cargo insta review
c764517d
plredmond [ruff F401 #10390 #10391] rebase and change an argument to an altered…
1405baee
plredmond [ruff F401 #10390 #10391] ruff format the test fixtures
56bec82e
plredmond [ruff F401 #10390 #10391] note that the empty py files are used by a …
b827bfcf
plredmond [ruff F401 #10390 #10391] cargo insta review for the reformatted test…
482cb755
plredmond [ruff F401 #10390 #10391] rename loop binding variables
667a9015
plredmond [ruff F401 #10390 #10391] flip incorrectly reversed preview-flag-check
c6a3ef4b
plredmond [ruff F401 #10390 #10391] restore the old condition used to enable/di…
5ead8778
plredmond [ruff F401 #10390 #10391] delete the init_unused_import_opt_in_to_fix…
1800eb79
plredmond [ruff F401 #10390 #10391] add information to unused-import-context; u…
37c5152d
plredmond [ruff F401 #10390 #10391] attach context to import-bindings earlier, …
76608fe8
plredmond [ruff F401 #10390 #10391] rename to_explicit -> to_reexport
50d37b6d
plredmond [ruff F401 #10390 #10391] pass iterators to fix_by_* methods instead …
130ce571
plredmond [ruff F401 #10390 #10391] better (but not perfect) help text
18c30010
plredmond plredmond force pushed from c45124db to 18c30010 1 year ago
charliermarsh
charliermarsh commented on 2024-05-01
charliermarsh
charliermarsh commented on 2024-05-01
charliermarsh
charliermarsh commented on 2024-05-01
charliermarsh
MichaReiser
MichaReiser commented on 2024-05-01
plredmond optimize a shortcircuiting boolean expression per micha
53d68075
plredmond use an array instead of a vec per micha
c8876b26
plredmond [ruff F401 #10390 #10391] swap arg order; move imports to top level
71e191ad
charliermarsh
charliermarsh commented on 2024-05-01
plredmond correct level to is_first_party
dacbe736
plredmond
plredmond
plredmond
charliermarsh
charliermarsh
charliermarsh
charliermarsh approved these changes on 2024-05-02
charliermarsh
charliermarsh approved these changes on 2024-05-02
plredmond charlie patch to remove the unfinished dunder_all mutation
31768b6f
plredmond plredmond merged 59afff0e into main 1 year ago
plredmond plredmond deleted the ruff.F401 branch 1 year ago
charliermarsh
dhruvmanila dhruvmanila added rule

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone