ruff
[`flake8-pyi`] Implement `PYI059` (`generic-not-last-base-class`)
#11233
Merged

[`flake8-pyi`] Implement `PYI059` (`generic-not-last-base-class`) #11233

AlexWaygood merged 18 commits into astral-sh:main from tusharsadhwani:pyi-059
tusharsadhwani
tusharsadhwani [flake8-pyi] Implement PYI059
51ea3068
tusharsadhwani add negative cases to pyi test case
1f303fd0
tusharsadhwani improve tests to use attribute as well
586c8d1e
tusharsadhwani tusharsadhwani requested a review from AlexWaygood AlexWaygood 2 years ago
tusharsadhwani
zanieb
zanieb
tusharsadhwani
zanieb
github-actions
tusharsadhwani
tusharsadhwani Add auto fix
16ac12a2
tusharsadhwani clippy
68aa9348
tusharsadhwani Make issue non fixable if multiple generics are found in bases
7e3a5d2b
tusharsadhwani clippy fix
97a9f937
AlexWaygood
AlexWaygood commented on 2024-05-03
tusharsadhwani [wip] Apply suggestions from code review
84a3edde
AlexWaygood
tusharsadhwani cleanup code and add bare generic test case
3cf3ed3a
tusharsadhwani i thought i set a pre commit hook for clippy
ed30b1a1
AlexWaygood
AlexWaygood commented on 2024-05-03
tusharsadhwani raise diagnostic on bases list
26df9fef
AlexWaygood
AlexWaygood commented on 2024-05-03
tusharsadhwani preserve comments between the two bases
281cf096
AlexWaygood
AlexWaygood commented on 2024-05-03
tusharsadhwani refactor to avoid some unwraps
2c828178
AlexWaygood
AlexWaygood commented on 2024-05-03
tusharsadhwani Update crates/ruff_linter/src/rules/flake8_pyi/rules/generic_not_last…
587d5a23
tusharsadhwani fmt
0b28a2e8
AlexWaygood
AlexWaygood commented on 2024-05-06
AlexWaygood
AlexWaygood Remove remaining `unwrap()` and `expect()` calls in `generate_fix()`
6fce0fd8
AlexWaygood
tusharsadhwani use argument helpers
fc70de69
tusharsadhwani
AlexWaygood Small touch-ups
7750c914
AlexWaygood
AlexWaygood approved these changes on 2024-05-07
AlexWaygood AlexWaygood changed the title [flake8-pyi] Implement PYI059 [`flake8-pyi`] Implement `PYI059` (`generic-not-last-base-class`) 2 years ago
AlexWaygood AlexWaygood enabled auto-merge (squash) 2 years ago
AlexWaygood AlexWaygood merged bc3f4fa3 into main 2 years ago
tusharsadhwani tusharsadhwani deleted the pyi-059 branch 2 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone