ruff

F401 - Recommend adding unused import bindings to `__all__`

#11314

Merged

charlie patch w/proto dunder_all finder

find_dunder_all_expr implemented

pass ExprList to fix_by_reexporting

slight cleanup of branch arms readability

rename F401_25__all fixture test to F401_25__all_nonempty

remove unnecessary pattern match

new field in ImportBinding which is the name of the binding

change fix_bind_reexporting call add_to_dunder_all with the list of binding names, /not import member_names/ to fix bug handling renamed imports; also to use a slice imput (per micha)

uncomment and review test cases for F401_25 fixture test

add edit to insert binding names into __all__

fixture tests to more thoroughly explore the cases of the "add to __all__" feature

cargo clippy edits -- map..or to map_or and single-pattern match to if..let

include the binding name in UnusedImport; when it is not the suffix of the qualified name, use the binding name in the fix title

accept fixture test changes that show the binding when it differs from the qualified name

accept stylist argument to place correct quotes around binders added to __all__; use "]".text_len() instead of specifying a TextSize manually

use Expr instead of ExprList to convey dunder_all value to the edit-producing function b/c we want to also support tuples

clippy again

change make_redundant_alias to take an iter of Cow to simplify caller

rewrite add_to_dunder_all and its tests

shakes fist at cloud and yells, "Clippy!!!"

change message for redundant-aliases

use binding method instead of accessing the field

use filter_map followed by last to obtain the first __all__ binding

update fixture test to reflect that we add to the first binding of __all__

fixture test to demonstrate how we treat __all__ followed by a conditional mutation

do not offer a fix to add to __all__ when there is more than one __all__; fall back to the redundant-alias recommending behavior

delete F401_29 fixture test

rename F401_30 fixture test to F401_29

add unused-import case to F401_29 fixture test

change `find_dunder_all_expr` to `find_dunder_all_exprs` and track the number of matches on UnusedImportContext::Init; update fix-title messaging and fix_by_reexporting to only fix when zero or one __all__ are present; update fixture tests

change find_dunder_all_exprs to return /all/ such exprs regardless of their types; the add_to_dunder_all fix-producing function will still only produce fixes for lists & tuples; update fixture test with non tuple/list __all__ to not recommend redundant alias

change fix-title for redundant alias case to format itself and return early

use if-let instead of match with empty branch per alex

Update crates/ruff_linter/src/fix/edits.rs

wording improvement per alex

replace into::Into with Cow::from to make conversion explicit

improve the wording of "add unused import to __all__" message per alex

reformat a function -- noop w.r.t. the tests

remove a now unnecessary branch, which also makes the overall PR diff smaller

call .end() directly instead of going through .range or .range(); remove unnecessary import paths

readd erroneously removed newlines to fixture snaps

ruff format the fixture __init__.py files

cargo insta review -- accept whitespace changes (see `git diff -w`)

clippy fix -- replace closure with static reference to method

collect only 2 `__all__` definitions and then stop pulling the iterator

Revert "collect only 2 `__all__` definitions and then stop pulling the iterator"

remove the qualified-name field from UnusedImport in favor of the binding-name field (named as .name); update fixture test results

Revert "remove the qualified-name field from UnusedImport in favor of the binding-name field (named as .name); update fixture test results"