ruff
[ruff] Implement `incorrectly-parenthesized-tuple-in-subscript` (`RUF031`)
#12480
Merged

[ruff] Implement `incorrectly-parenthesized-tuple-in-subscript` (`RUF031`) #12480

dylwil3
dylwil3
dylwil3 dylwil3 marked this pull request as draft 1 year ago
dylwil3 dylwil3 marked this pull request as ready for review 1 year ago
MichaReiser MichaReiser added rule
MichaReiser
MichaReiser MichaReiser added needs-decision
AlexWaygood
dylwil3
dylwil3 dylwil3 marked this pull request as draft 1 year ago
github-actions
dylwil3 dylwil3 marked this pull request as ready for review 1 year ago
dylwil3
MichaReiser
MichaReiser commented on 2024-08-03
dylwil3
dylwil3 dylwil3 changed the title [ruff] Implement `parentheses-in-tuple-slices` (`RUF031`) [ruff] Implement `bad-format-tuple-in-getitem` (`RUF031`) 1 year ago
MichaReiser
AlexWaygood
MichaReiser
AlexWaygood
MichaReiser
MichaReiser commented on 2024-08-05
MichaReiser MichaReiser removed needs-decision
MichaReiser MichaReiser added accepted
dylwil3
dylwil3 dylwil3 changed the title [ruff] Implement `bad-format-tuple-in-getitem` (`RUF031`) [ruff] Implement `incorrectly-parenthesized-tuple-in-getitem` (`RUF031`) 1 year ago
MichaReiser
MichaReiser approved these changes on 2024-08-07
AlexWaygood
AlexWaygood commented on 2024-08-07
dylwil3 dylwil3 requested a review from carljm carljm 1 year ago
AlexWaygood
dylwil3 dylwil3 changed the title [ruff] Implement `incorrectly-parenthesized-tuple-in-getitem` (`RUF031`) [ruff] Implement `incorrectly-parenthesized-tuple-in-subscript` (`RUF031`) 1 year ago
AlexWaygood AlexWaygood removed review request from carljm carljm 1 year ago
dylwil3
AlexWaygood
dylwil3 add test fixture for lint rule
8acd4095
dylwil3 add test cases with newlines
e9aa21cf
dylwil3 add module to check for parens around tuples in getitem calls
d59408f7
dylwil3 add to codes as RUF031
7882fcd9
dylwil3 add pointer to test case for rule
be86fe95
dylwil3 implement rule for subscript expressions in checker
55c334af
dylwil3 update schema
ec086e8a
dylwil3 add snapshot for RUF031
284a1946
dylwil3 reformat example
9513c9c1
dylwil3 begin adding settings functionality to ruff ruleset
5b0a92a0
dylwil3 rename rule and add config for ruff
61106a6e
dylwil3 update rule fix and violation logic to respect configuration
f3db34e8
dylwil3 update snapshot
3f5d5bba
dylwil3 update schema
a0e7b04c
dylwil3 fix ruff settings namespace copypasta mistake and regenerate snapshot
0c339ab6
dylwil3 add test case with parens on setting
c2e350bc
dylwil3 make ruff an option group
5e1e0a4c
dylwil3 rename rule to satisfy convention
a6969617
dylwil3 change rule and config option names
209add0d
dylwil3 typo
bf5947d7
dylwil3 Use `let .. else`
2a895b60
dylwil3 resolve comments
dedda82f
dylwil3 update snapshot
d8ea3a20
dylwil3 treat single element tuples as well
f7ff6a35
dylwil3 update snapshot
dd3d881e
dylwil3 clippy
cec2241b
dylwil3 typo and subscript instead of getitem
96fcb284
dylwil3 update snapshot again
bbe18013
dylwil3 change name of setting
5a83811f
dylwil3 update schema
4cc9eb54
dylwil3 update docstrings
767ae993
AlexWaygood AlexWaygood force pushed from 858bf05b to 767ae993 1 year ago
AlexWaygood
AlexWaygood
AlexWaygood commented on 2024-08-07
dylwil3 rename module and remove clippy allow
b95f0689
dylwil3 match to if/else
84afc6e7
dylwil3
AlexWaygood
AlexWaygood approved these changes on 2024-08-07
AlexWaygood Apply suggestions from code review
ccf47a7a
AlexWaygood AlexWaygood force pushed from ba508228 to e165fa5c 1 year ago
AlexWaygood AlexWaygood enabled auto-merge (squash) 1 year ago
AlexWaygood final nits
4ba055dd
AlexWaygood AlexWaygood force pushed from e165fa5c to 4ba055dd 1 year ago
AlexWaygood AlexWaygood merged 7997da47 into main 1 year ago
dylwil3 dylwil3 deleted the getitem-with-parens-tuple branch 1 year ago
AlexWaygood
neutrinoceros
dhruvmanila dhruvmanila added preview

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone