ruff
[red knot] Fix narrowing for '… is not …' type guards, add '… is …' type guards
#13758

Merged

[red knot] Fix narrowing for '… is not …' type guards, add '… is …' type guards #13758

sharkdp merged 11 commits into main from david/type-narrowing-updates

[red knot] Fix narrowing for 'is not' conditionals

09eeee99

sharkdp requested a review from

carljm 1 year ago

sharkdp requested a review from

MichaReiser 1 year ago

sharkdp requested a review from

AlexWaygood 1 year ago

sharkdp added ty

sharkdp commented on 2024-10-15

Move Type::Todo to the false-branch

e241c422

MichaReiser approved these changes on 2024-10-15

The empty tuple type is a singleton type

749f176a

AlexWaygood requested changes on 2024-10-15

Fix behavior for tuple types

e069381a

Use custom type instead of LiteralInt

a95b4d57

Add explanation to 'is not' test

b425e6a3

Add TODO comment

da842bbc

AlexWaygood approved these changes on 2024-10-15

Shorten comment regarding union types

edfaf896

Add TODO comment

b219c6fc

Handle non-singleton 'is not' case

79f809cd

AlexWaygood commented on 2024-10-15

Modules are singleton types as well

9169e351

AlexWaygood approved these changes on 2024-10-15

sharkdp merged 74bf4b06 into main 1 year ago

sharkdp deleted the david/type-narrowing-updates branch 1 year ago

carljm commented on 2024-10-15

Reviewers

AlexWaygood

MichaReiser

carljm

Assignees

No one assigned

Labels

Milestone

No milestone

ruff [red knot] Fix narrowing for '… is not …' type guards, add '… is …' type guards #13758 Merged

[red knot] Fix narrowing for '… is not …' type guards, add '… is …' type guards #13758

ruff
[red knot] Fix narrowing for '… is not …' type guards, add '… is …' type guards
#13758

Merged