ruff
Remove AST-node dependency from `FunctionType` and `ClassType`
#14087

Merged

Remove AST-node dependency from `FunctionType` and `ClassType` #14087

MichaReiser merged 6 commits into main from micha/remove-ast-dependencies-from-type

MichaReiser changed the title ~~Move `ScopeId::node` to `Scope` to avoid depending on AST node~~ Remove AST-node dependency from `Type` 1 year ago

MichaReiser added ty

MichaReiser force pushed from 817ee80d to 7908514f 1 year ago

MichaReiser force pushed from 079e46a9 to 1fc3dc4d 1 year ago

MichaReiser force pushed from 1fc3dc4d to a1a709f7 1 year ago

MichaReiser changed the title ~~Remove AST-node dependency from `Type`~~ Remove AST-node dependency from `FunctionType` and `ClassType` 1 year ago

MichaReiser force pushed from a1a709f7 to 6d5f492f 1 year ago

MichaReiser commented on 2024-11-04

MichaReiser force pushed from 0b802268 to 6d5f492f 1 year ago

Skylion007 commented on 2024-11-04

MichaReiser force pushed from 6d5f492f to f93cea20 1 year ago

MichaReiser force pushed from f93cea20 to 4bb6209d 1 year ago

MichaReiser marked this pull request as ready for review 1 year ago

MichaReiser requested a review from

carljm 1 year ago

MichaReiser requested a review from

AlexWaygood 1 year ago

MichaReiser requested a review from

sharkdp 1 year ago

MichaReiser force pushed from 4bb6209d to a4f8f95f 1 year ago

AlexWaygood commented on 2024-11-04

MichaReiser force pushed from a4f8f95f to 51a99830 1 year ago

AlexWaygood approved these changes on 2024-11-04

carljm approved these changes on 2024-11-04

dhruvmanila commented on 2024-11-05

Move `ScopeId::node` to `Scope` to avoid depending on AST node

44e8223b

Remove `Definition` dependency from Function and Class type

a0b02ba4

Apply suggestions from code review

aaa407eb

MichaReiser force pushed from f3bec2d3 to 26cd7ed3 1 year ago

Add test that `call` doesn't add a dependency to the callee's file

da485eda

Add comment to `Unpack`

969461f9

MichaReiser force pushed from 26cd7ed3 to 969461f9 1 year ago

MichaReiser enabled auto-merge (squash) 1 year ago

AlexWaygood commented on 2024-11-05

Update crates/red_knot_python_semantic/src/types.rs

eb972463

MichaReiser merged 4323512a into main 1 year ago

MichaReiser deleted the micha/remove-ast-dependencies-from-type branch 1 year ago

Reviewers

AlexWaygood

carljm

dhruvmanila

Skylion007

sharkdp

Assignees

No one assigned

Labels

Milestone

No milestone

ruff Remove AST-node dependency from `FunctionType` and `ClassType` #14087 Merged

Remove AST-node dependency from `FunctionType` and `ClassType` #14087

ruff
Remove AST-node dependency from `FunctionType` and `ClassType`
#14087

Merged