PR #15811 [red-knot] Implicit instance attributes

[red-knot] Implicit instance attributes #15811

sharkdp merged 11 commits into main from david/implicit-instance-attributes

sharkdp added ty

sharkdp commented on 2025-01-29

sharkdp force pushed from b216fc3b to 9f5ffe1d 247 days ago

sharkdp force pushed from aa943023 to e5fdf9c8 246 days ago

sharkdp force pushed from e5fdf9c8 to a5e73c26 246 days ago

sharkdp force pushed from a5e73c26 to 49bec2ff 246 days ago

sharkdp force pushed from 49bec2ff to 362eb8a8 246 days ago

sharkdp marked this pull request as ready for review 246 days ago

sharkdp requested a review from

carljm 246 days ago

sharkdp requested a review from

MichaReiser 246 days ago

sharkdp requested a review from

AlexWaygood 246 days ago

sharkdp commented on 2025-01-31

AlexWaygood commented on 2025-01-31

carljm commented on 2025-01-31

carljm approved these changes on 2025-01-31

MichaReiser commented on 2025-02-02

[red-knot] Implicit instance attributes

04e26ace

Avoid allocations for names

59d112f6

Add (passing) tests for (a, b) = … assignments in class body

b2158bd4

Remove outdated TODO

83c3be2b

Turn ScopeInfo into a struct

84f9b6cd

Add comment explaining why we union with Unknown

8068837e

Make operator precedence explicit, add comment

c8d08071

Use enum instead of bool

b12357d1

Use ScopeKind instead of custom BuilderScopeKind enum

4ed94c68

sharkdp force pushed from 128679ee to 4ed94c68 243 days ago

MichaReiser commented on 2025-02-03

Add fine-grained salsa queries to avoid re-inferring types for unrela…

43a3482e

Use Name instead of &'db str

f54baed1

MichaReiser commented on 2025-02-03

MichaReiser approved these changes on 2025-02-03

sharkdp merged 102c2eec into main 243 days ago

sharkdp deleted the david/implicit-instance-attributes branch 243 days ago

Reviewers

MichaReiser

carljm

AlexWaygood

Assignees

No one assigned

Labels

Milestone

No milestone

ruff [red-knot] Implicit instance attributes #15811 Merged

[red-knot] Implicit instance attributes #15811

ruff
[red-knot] Implicit instance attributes
#15811

Merged