[red-knot] Detect semantic syntax errors #17463
ntBre
merged
29 commits into
main
from
brent/semantic-errors-red-knot
ntBre
commented
on 2025-04-18
[red-knot] Detect semantic syntax errors
1b1ff1f6
add SemanticIndexBuilder::seen_module_docstring_boundary
74353f05
implement in_async_context and in_generator_scope
b09fcee3
add failing mdtest
f37022a9
emit diagnostics and pass mdtest
46b022ee
pass existing mdtests
2764c451
add mdtests covering all context methods
507b737e
upcast explicitly for msrv tests
60acba6b
avoid unrelated errors in invalid.md
63fd71d3
avoid unrelated errors in comprehensions/basic.md
773e7a1c
remove backticks on async comprehension and test
c916bc30
replace current_scope_is_global_scope with context method
82f848c3
update notebook check
f6a4213f
remove now-unused is_module method
bd1d9b1f
dhruvmanila
commented
on 2025-04-21
dhruvmanila
commented
on 2025-04-21
dhruvmanila
commented
on 2025-04-21
dhruvmanila
commented
on 2025-04-21
dhruvmanila
commented
on 2025-04-21
dhruvmanila
commented
on 2025-04-21
dhruvmanila
approved these changes
on 2025-04-21
seen_docstring_boundary -> seen_module_docstring_boundary
4b2fac9d
use expect_function instead of if-let
bfbc79f5
skip checking a file if it's not open
add4f6b0
cache SemanticIndexBuilder::python_version
9ac43a98
add TypeCheckDiagnostic::extend_diagnostics
7db66855
remove SemanticSyntaxContext::seen_module_docstring_boundary
3d11ef72
cache is_file_open call
5e172cc8
Merge branch 'main' into brent/semantic-errors-red-knot
af437576
revert is_file_open check entirely
7a1e1ab9
restore is_file_open check, but only for pushing errors
b32372c7
MichaReiser
commented
on 2025-04-22
MichaReiser
commented
on 2025-04-22
move semantic checker fields to their own group
02dfc232
make semantic_checker optional
e32c188e
restore SemanticSyntaxContext::source method and use OnceCell
ebccf416
delete is_file_open check in favor of Option approach
57866a09
Revert "make semantic_checker optional"
931fcf12
Reviewers
Assignees
No one assigned
Labels
ty
Milestone
No milestone
Login to write a write a comment.
Login via GitHub