`F523` autofix as unsafe if there's a call with side effect
#18839

Merged

[`pyflakes`] Mark `F504`/`F522`/`F523` autofix as unsafe if there's a call with side effect #18839

MichaReiser merged 6 commits into astral-sh:main from LaBatata101:fix-F504

[`pyflakes`] Mark `F504`/`F522`/`F523` autofix as unsafe if there's a…

faa076d1

Update docs

7eff2b1a

dscorbett commented on 2025-06-20

Use `contains_effect`

63ec1807

LaBatata101 requested a review from

MichaReiser 170 days ago

LaBatata101 changed the title ~~[`pyflakes`] Mark `F504`/`F522`/`F523` autofix as unsafe if there's a call expression in the format part~~ [`pyflakes`] Mark `F504`/`F522`/`F523` autofix as unsafe if there's a call with side effect 170 days ago

MichaReiser removed review request from

MichaReiser 170 days ago

MichaReiser commented on 2025-06-25

Docs

8efb731a

MichaReiser commented on 2025-06-25

Only mark fix as unsafe if the unused argument has a side effect

93fc2b19

LaBatata101 requested a review from

MichaReiser 169 days ago

MichaReiser added fixes

Simplify side effect checks

aad1ee5b

MichaReiser approved these changes on 2025-06-26

MichaReiser enabled auto-merge (squash) 169 days ago

MichaReiser merged 2362263d into main 169 days ago

Reviewers

MichaReiser

dscorbett

Assignees

No one assigned

Labels

fixes

Milestone

No milestone

ruff [`pyflakes`] Mark `F504`/`F522`/`F523` autofix as unsafe if there's a call with side effect #18839 Merged

[`pyflakes`] Mark `F504`/`F522`/`F523` autofix as unsafe if there's a call with side effect #18839

ruff
[`pyflakes`] Mark `F504`/`F522`/`F523` autofix as unsafe if there's a call with side effect
#18839

Merged