ruff
[ty] Fix empty spans following a line terminator and unprintable character spans in diagnostics
#19535

Merged

[ty] Fix empty spans following a line terminator and unprintable character spans in diagnostics #19535

ntBre merged 21 commits into main from brent/empty-span-after-line-terminator

ntBre added internal

ntBre added diagnostics

ntBre force pushed from d0c91941 to b9d27c63 151 days ago

ntBre commented on 2025-07-25

add test demonstrating the problem

366841e3

port fix to ruff_db

7c31a78f

add a test for unprintable characters

02560f75

working version with partial SourceCode port

f7d28b1e

accept fixed snapshot for unprintable characters

0c4652a0

port over a minimal LineWidthBuilder and IndentWidth

c22449c6

fix docstring

d7461459

move snapshots back to their own files for easier diffing

fffbb7df

fix panic caused by replace_whitespace_and_unprintable

fe82d7be

delete debugging test handled by full snapshot

665909e4

ntBre force pushed from b9d27c63 to 665909e4 151 days ago

strip down LineWidthBuilder a bit more

6180806f

ntBre changed the title ~~Fix empty spans following a line terminator in `ruff_db`~~ Fix empty spans following a line terminator and unprintable character spans in `ruff_db` 151 days ago

ntBre marked this pull request as ready for review 151 days ago

ntBre requested a review from

carljm 151 days ago

ntBre requested a review from

MichaReiser 151 days ago

ntBre requested a review from

AlexWaygood 151 days ago

ntBre requested a review from

sharkdp 151 days ago

ntBre requested a review from

dcreager 151 days ago

ntBre removed review request from

dcreager 151 days ago

ntBre removed review request from

carljm 151 days ago

ntBre removed review request from

sharkdp 151 days ago

ntBre removed review request from

AlexWaygood 151 days ago

ntBre requested a review from

BurntSushi 151 days ago

MichaReiser added ty

MichaReiser changed the title ~~Fix empty spans following a line terminator and unprintable character spans in `ruff_db`~~ Fix empty spans following a line terminator and unprintable character spans in Diagnostics 151 days ago

MichaReiser changed the title ~~Fix empty spans following a line terminator and unprintable character spans in Diagnostics~~ Fix empty spans following a line terminator and unprintable character spans in diagnostics 151 days ago

MichaReiser commented on 2025-07-26

MichaReiser approved these changes on 2025-07-26

MichaReiser removed internal

MichaReiser changed the title ~~Fix empty spans following a line terminator and unprintable character spans in diagnostics~~ [ty] Fix empty spans following a line terminator and unprintable character spans in diagnostics 151 days ago

inline LineWidthBuilder, move variables closer to their use

9c82529f

combine character matches

30316731

strip down tests and move them to ruff_db

a4f74340

clippy

cdef1a17

make the comments match the tests

f6064536

delete unused secondary codes and un-pub the method

a1b3dcfc

temporarily revert original_range, add panicking test case

f5410bfc

restore original_range, accept snapshot

5ae6367a

handle `\r` in fix_up_empty_spans_after_line_terminator

2e2ef661

BurntSushi approved these changes on 2025-07-28

avoid collecting `original_ranges`

c42ea1da

ntBre merged a54061e7 into main 148 days ago

ntBre deleted the brent/empty-span-after-line-terminator branch 148 days ago

Reviewers

MichaReiser

BurntSushi

Assignees

No one assigned

Labels

ty diagnostics

Milestone

No milestone

ruff [ty] Fix empty spans following a line terminator and unprintable character spans in diagnostics #19535 Merged

[ty] Fix empty spans following a line terminator and unprintable character spans in diagnostics #19535

ruff
[ty] Fix empty spans following a line terminator and unprintable character spans in diagnostics
#19535

Merged