ruff
Display diffs for `ruff format --check` and add support for different output formats
#20443
Merged
Go
Login via GitHub
Home
Pricing
FAQ
Install
Login
via GitHub
Overview
Commits
37
Changes
View On
GitHub
Display diffs for `ruff format --check` and add support for different output formats
#20443
ntBre
merged 37 commits into
main
from
brent/formatter-diagnostics
ntBre
force pushed
from
64cb945f
to
8c986740
132 days ago
ntBre
force pushed
from
8c986740
to
14fcf016
132 days ago
ntBre
force pushed
from
6c60142c
to
dcce3072
128 days ago
ntBre
force pushed
from
dcce3072
to
29cd7fa1
128 days ago
ntBre
force pushed
from
29cd7fa1
to
5996dc3f
126 days ago
ntBre
added
preview
ntBre
added
diagnostics
ntBre
added
formatter
add DiagnosticId::Unformatted
4620604a
add --output-format to the ruff format cli
92208abd
allow tempdir_filter to take any AsRef<Path>
041b35da
respect show_fix_status for `full` output
9bb4374f
suppress the URL for all non-lint DiagnosticIds
9cffdd80
fix a couple of Rome references
5bfe3f24
add `CellOffsets::ranges` helper
76e63b36
convert FormatPathResults to Diagnostics just before rendering
7e48156a
build a real notebook index and render cell diffs
a5ec195c
convert errors to diagnostics too
4ea16b7d
allow passing a header offset into annotate-snippets
39f96cc9
factor out PanicError::to_diagnostic_message
a43fa932
add error tests, set_file_level, and improve panic formatting
959f55ae
ntBre
force pushed
from
5996dc3f
to
959f55ae
125 days ago
ntBre
marked this pull request as ready for review
125 days ago
ntBre
requested a review
from
carljm
125 days ago
ntBre
requested a review
from
MichaReiser
125 days ago
ntBre
requested a review
from
sharkdp
125 days ago
ntBre
requested a review
from
dcreager
125 days ago
ntBre
requested a review
from
BurntSushi
125 days ago
ntBre
requested a review
from
dhruvmanila
125 days ago
ntBre
removed review request
from
dcreager
125 days ago
ntBre
removed review request
from
carljm
125 days ago
ntBre
removed review request
from
BurntSushi
125 days ago
ntBre
removed review request
from
sharkdp
125 days ago
ntBre
removed review request
from
dhruvmanila
125 days ago
ntBre
changed the title
[WIP] Use `Diagnostic`s for rendering formatting results
Use `Diagnostic`s for rendering formatting results
125 days ago
MichaReiser
commented on 2025-09-26
use FormatResult::diff for checking, revert other changes
2ce8f808
point out preview restriction on format --output-format
007a22f1
emit a warning for non-preview --output-format usage
451dc0c4
sort errors and diagnostics together
78fdc60d
factor out create_panic_diagnostic, reuse in the linter
28ebcd55
delete TODO for ignore::Errors
090468d9
use FormatError for PrintError
723d1d56
add DisplayParseError::error and render the ParseErrorType directly
05faf43c
calculate a real range for the diagnostics
ed63b7e4
reuse FormatCommandError::Write instead of Diff
c1a3b44a
DiagnosticId::RangeFormatNotebook -> InvalidCliOption
73eb86d0
DiagnosticId::FormatError -> InternalError
aee8fd36
add a todo about the offset hack
0668704f
file_level -> hide_snippet
519b6fa8
MichaReiser
approved these changes on 2025-09-29
debug assert FormatResult::Diff
18640189
narrow edit range to modified lines
aa532d78
account for context lines when computing the line number width
cbf7d1f3
mark FormatModuleError::InvalidSyntax as an internal error
7b8b4426
Merge branch 'main' into brent/formatter-diagnostics
57db0315
use render_diagnostics helper
74de549c
fix range narrowing for strict prefixes
6a72314d
range -> modified_range, restore previous range references
793f5261
only restrict the end of the script line counting
bf48b9bc
MichaReiser
approved these changes on 2025-09-30
use loop for prefix_length too, use guarded break for suffix
bedfc6fd
ntBre
changed the title
Use `Diagnostic`s for rendering formatting results
Display diffs for `ruff format --check` and add support for different output formats
120 days ago
ntBre
merged
2b1d3c60
into main
120 days ago
ntBre
deleted the brent/formatter-diagnostics branch
120 days ago
Login to write a write a comment.
Login via GitHub
Reviewers
MichaReiser
Assignees
No one assigned
Labels
formatter
preview
diagnostics
Milestone
No milestone
Login to write a write a comment.
Login via GitHub