PR #21385 Keep lambda parameters on one line and parenthesize the body if it expands

baseline test cases

ntBre committed 8 days ago

keep lambda parameters on a single line

ntBre committed 8 days ago

wip: parenthesize long lambda bodies

ntBre committed 8 days ago

add a poorly formatted case from the ecosystem report

ntBre committed 8 days ago

add an unstable test case from ecosystem report

ntBre committed 8 days ago

rough draft of ExprLambdaLayout::Assignment

ntBre committed 8 days ago

add another bad case from the ecosystem check

ntBre committed 8 days ago

fix binary expression in lambda in return

ntBre committed 8 days ago

add another bad test case from the ecosystem report

ntBre committed 8 days ago

propagate lambda layout for annotated assignments

ntBre committed 8 days ago

another bad test for long bodies with their own parens

ntBre committed 8 days ago

possibly bad test for triple-quoted f-strings

ntBre committed 8 days ago

exclude call and subscript expressions from has_own_parentheses

ntBre committed 8 days ago

avoid lambda special-casing in maybe_parenthesize_expression

ntBre committed 8 days ago

add some assignment tests with parentheses and comments

ntBre committed 8 days ago

add a couple more test cases

ntBre committed 8 days ago

use write!

ntBre committed 8 days ago

create id only in indented case, update group name

ntBre committed 8 days ago

avoid nesting groups

ntBre committed 8 days ago

add too-eagerly parenthesized case from ecosystem

ntBre committed 8 days ago

apply Micha's patch, fixing everything?

ntBre committed 8 days ago

fix snapshot changes for cases with comments

ntBre committed 8 days ago

fix another ecosystem call expansion

ntBre committed 7 days ago

use parenthesize_if_expands for fluent call chains

ntBre committed 7 days ago

add wrapping case from the ecosystem check

ntBre committed 7 days ago

expand parent if the lambda body breaks

ntBre committed 7 days ago

remove comment

ntBre committed 7 days ago

combine preview checks

ntBre committed 6 days ago

add comments and some supporting tests

ntBre committed 6 days ago

copy mapper test case from can_omit_optional_parentheses

ntBre committed 6 days ago

gate optional_parentheses branches behind stable

ntBre committed 6 days ago

Merge branch 'main' into brent/indent-lambda-params

ntBre committed 6 days ago

mirror comment handling from `maybe_parenthesize_expression`

ntBre committed 6 days ago

add some more tests

ntBre committed 6 days ago

check comment case first

ntBre committed 6 days ago

add another dangling eol case

ntBre committed 6 days ago

improve dangling header comment placement

ntBre committed 6 days ago

clippy

ntBre committed 6 days ago

add another dangling case between lambda and parameters

ntBre committed 5 days ago

more tests

ntBre committed 5 days ago

block indent and trailing comments

ntBre committed 5 days ago

leading_comments in block

ntBre committed 5 days ago

add more cases without parameters

ntBre committed 5 days ago

try parenthesizing the body without parameters

ntBre committed 5 days ago

Revert "try parenthesizing the body without parameters"

ntBre committed 5 days ago

factor out preview variable

ntBre committed 5 days ago

factor out parameters_have_comments

ntBre committed 5 days ago

pairing

ntBre committed 5 days ago

wip

ntBre committed 5 days ago

revert the last two commits, back to a stable formatting

ntBre committed 5 days ago

fix assignment instability with dangling comments

ntBre committed 5 days ago

Reapply "try parenthesizing the body without parameters"

ntBre committed 5 days ago

fix assignment instability without parameters too

ntBre committed 5 days ago

move comments within lambda parameters to dangling lambda comments

ntBre committed 2 days ago

format new dangling comments

ntBre committed 2 days ago

apply patch

ntBre committed 2 days ago

clippy

ntBre committed 2 days ago

accept snapshots

ntBre committed 2 days ago

pass preview to handle_lambda_comment

ntBre committed 1 day ago

Merge branch 'main' into brent/indent-lambda-params

ntBre committed 1 day ago

add broken test cases

ntBre committed 1 day ago

avoid breaking when the first parameter has leading comments

ntBre committed 1 day ago

Merge branch 'brent/fix-kwargs' into brent/indent-lambda-params

ntBre committed 1 day ago

update snaps

ntBre committed 1 day ago

revert preview and comment placement changes

ntBre committed 1 day ago

revert FormatParameters changes

ntBre committed 1 day ago

make comments leading on parameter_s_

ntBre committed 1 day ago

simplify check with parameters.start() == parameter.start()

ntBre committed 1 day ago

simplify a bit further

ntBre committed 1 day ago

update comments

ntBre committed 1 day ago

remove redundant parameters check

ntBre committed 1 day ago

update lambda comment

ntBre committed 1 day ago

Merge branch 'brent/fix-kwargs' into brent/indent-lambda-params

ntBre committed 1 day ago

clean up deref

ntBre committed 1 day ago

Merge branch 'main' into brent/indent-lambda-params

ntBre committed 1 day ago

fix lambda formatting in assignments

ntBre committed 1 day ago

factor out maybe_parenthesize_lambda

ntBre committed 1 day ago

re-apply 'pass preview to handle_lambda_comment'

ntBre committed 1 day ago

move preview comment handling mostly into placement.rs

ntBre committed 1 day ago

add preview function taking a PreviewMode

ntBre committed 21 hours ago

move tokenizer checks into the stable branch

ntBre committed 21 hours ago

update lambda placement docs

ntBre committed 21 hours ago

maybe_parenthesize_lambda -> maybe_parenthesize_value

ntBre committed 20 hours ago

add a few more call tests with comments

ntBre committed 19 hours ago

move dangling comment handling back out of placement.rs

ntBre committed 17 hours ago

factor out FormatBody

ntBre committed 17 hours ago

ruff Keep lambda parameters on one line and parenthesize the body if it expands #21385 Open

ruff
Keep lambda parameters on one line and parenthesize the body if it expands
#21385

Open