PR #21646 [ty] Implement `typing.final` for methods

[ty] Implement `typing.final` for methods #21646

AlexWaygood merged 14 commits into main from alex/final-method

AlexWaygood added ty

AlexWaygood force pushed from 64169218 to b9916af9 69 days ago

AlexWaygood force pushed from b9916af9 to 830e0848 69 days ago

AlexWaygood added ecosystem-analyzer

AlexWaygood force pushed from 830e0848 to 070e2c5b 69 days ago

AlexWaygood force pushed from 070e2c5b to 7e739c6a 69 days ago

AlexWaygood marked this pull request as ready for review 69 days ago

AlexWaygood requested a review from

carljm 69 days ago

AlexWaygood requested a review from

sharkdp 69 days ago

AlexWaygood requested a review from

dcreager 69 days ago

AlexWaygood requested a review from

MichaReiser 69 days ago

AlexWaygood commented on 2025-11-26

MichaReiser commented on 2025-11-27

[ty] Implement `typing.final` for methods

0e025d65

fix unrelated mdtest failure

b885cb72

another edge case

3ca26759

another edge case

47d07e21

another edge case

486caf5d

try to optimize

76ccc488

AlexWaygood force pushed from 56cd2aa1 to 623ca678 68 days ago

AlexWaygood commented on 2025-11-27

use a standalone query to check if it's a function definition

408895e8

AlexWaygood force pushed from 623ca678 to 408895e8 68 days ago

check if rules are enabled before doing expensive analysis

5cc8e66c

AlexWaygood requested a review from

MichaReiser 68 days ago

Merge branch 'main' into alex/final-method

9e65bb20

MichaReiser approved these changes on 2025-11-28

Update crates/ty_python_semantic/resources/mdtest/final.md

ce8d67e1

make recommendation clearer and add autofix

6d40d0e9

Add tests for possibly-undefined cases

cb520d50

AlexWaygood force pushed from 3a7eb080 to cb520d50 67 days ago

AlexWaygood commented on 2025-11-28

Avoid repetition in the primary diagnostic message

33915c15

AlexWaygood force pushed from 03e7236c to 33915c15 67 days ago

AlexWaygood enabled auto-merge (squash) 67 days ago

todo a couple more things

f8eb0d27

AlexWaygood force pushed from 4ddd64e0 to f8eb0d27 67 days ago

AlexWaygood merged 8bcfc198 into main 67 days ago

AlexWaygood deleted the alex/final-method branch 67 days ago

MichaReiser commented on 2025-11-29

Reviewers

MichaReiser

carljm

sharkdp

dcreager

Assignees

No one assigned

Labels

ty ecosystem-analyzer

Milestone

No milestone

ruff [ty] Implement `typing.final` for methods #21646 Merged

[ty] Implement `typing.final` for methods #21646

ruff
[ty] Implement `typing.final` for methods
#21646

Merged