ruff
Report diagnostics for invalid/unmatched range suppression comments
#21908
Merged

Report diagnostics for invalid/unmatched range suppression comments #21908

amyreese merged 28 commits into main from amy/unmatched-suppressions
amyreese
amyreese Define rule codes RUF103/104 for invalid/unmatched suppression comments
90f82c10
amyreese Report RUF104 unmatched suppression diagnostics
976a52c3
amyreese amyreese force pushed from 282450e3 to 7e9def93 51 days ago
astral-sh-bot
amyreese Report invalid suppression diagnostics
05f63c91
amyreese Todos
aa913534
amyreese amyreese changed the title Report diagnostics for unmatched range suppression comments Report diagnostics for invalid/unmatched range suppression comments 51 days ago
MichaReiser
amyreese Fix test cases causing panics
ebf01217
amyreese Move rule-enabled checks to local logic, extract some bits
2b6dc036
amyreese Generate invalid rule code diagnostics
bcd93740
amyreese Target the diagnostic at the code even if only one code in comment
58f57348
amyreese clippy
4793f52b
amyreese Document that implicit ranges will produce RUF104
c50026e3
amyreese amyreese force pushed from 100ed3f2 to 999a481e 50 days ago
amyreese amyreese marked this pull request as ready for review 50 days ago
amyreese amyreese requested a review from MichaReiser MichaReiser 50 days ago
amyreese amyreese requested a review from ntBre ntBre 50 days ago
MichaReiser MichaReiser added rule
MichaReiser MichaReiser added preview
MichaReiser
MichaReiser commented on 2025-12-12
ntBre
ntBre commented on 2025-12-12
MichaReiser
amyreese Add test case covering external rules
a6e9ca85
amyreese Correct pub usage
6cee82d2
amyreese Improve documentation for unmatched diagnostic
5b7d82ba
amyreese Mark invalid comment diagnostics as unsafe fixes
b659b5b7
amyreese Update test snapshots
83706a90
amyreese update wording in invalid rule code diagnostics
5c112af0
amyreese Revert "Target the diagnostic at the code even if only one code in co…
0f3c74f6
amyreese Avoid unnecessary assignments
f5532fff
amyreese
amyreese Use itertools unique
ea17270d
amyreese Handle external codes and redirects
b90f418e
amyreese Reorganize check_suppressions to iterate over valid/errors only once
5bdf0497
amyreese amyreese force pushed from 8a54e011 to 5bdf0497 44 days ago
amyreese clippy
0548374e
amyreese Fix docs
bafc629c
amyreese
amyreese amyreese requested a review from MichaReiser MichaReiser 44 days ago
amyreese amyreese requested a review from ntBre ntBre 44 days ago
MichaReiser
MichaReiser approved these changes on 2025-12-18
amyreese Only target the invalid rule code
a6c73ae1
amyreese Treat missing codes as invalid suppression comment, update error message
0e8b8aa8
amyreese Better implementation of highlighting only code for invalid rule codes
5f5bd056
amyreese More test cases, improve error/fix wording
b14a6ac1
amyreese Update comment to clarify unused external codes
78e85941
amyreese amyreese merged 3d334a31 into main 43 days ago
amyreese amyreese deleted the amy/unmatched-suppressions branch 43 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone