ruff
[ty] Enable narrowing for unions of TypedDict
#25188

Merged

[ty] Enable narrowing for unions of TypedDict #25188

charliermarsh merged 14 commits into main from charlie/td-required-keys

astral-sh-bot added ty

charliermarsh force pushed from c0688f46 to c22ebe70 81 days ago

charliermarsh force pushed from c22ebe70 to 250e1086 81 days ago

AlexWaygood commented on 2026-05-15

charliermarsh force pushed from ac900be4 to d98fa0e6 81 days ago

charliermarsh changed the title ~~[ty] View ecosystem results for synthesized TypedDict intersection~~ [ty] Enable narrowing for unions of TypedDict 81 days ago

charliermarsh marked this pull request as ready for review 81 days ago

charliermarsh requested a review from

carljm 81 days ago

charliermarsh requested a review from

sharkdp 81 days ago

charliermarsh requested a review from

dcreager 81 days ago

charliermarsh requested a review from

ibraheemdev 81 days ago

charliermarsh assigned

AlexWaygood 81 days ago

astral-sh-bot requested a review from

AlexWaygood 81 days ago

AlexWaygood commented on 2026-05-15

charliermarsh commented on 2026-05-15

charliermarsh marked this pull request as draft 81 days ago

charliermarsh force pushed from d98fa0e6 to efa66e3f 81 days ago

charliermarsh force pushed from efa66e3f to b8e85df3 81 days ago

charliermarsh force pushed from 164fe42f to 3c3c0fd5 81 days ago

charliermarsh force pushed from 3c3c0fd5 to b27ecd1c 81 days ago

charliermarsh force pushed from da109f46 to 88024534 81 days ago

charliermarsh commented on 2026-05-15

charliermarsh marked this pull request as ready for review 81 days ago

astral-sh-bot requested a review from

AlexWaygood 81 days ago

charliermarsh force pushed from 30f01ebb to 08145e06 81 days ago

AlexWaygood commented on 2026-05-15

charliermarsh commented on 2026-05-16

charliermarsh force pushed from 9a9d64b2 to 2d8d195e 66 days ago

[ty] View ecosystem results for synthesized TypedDict intersection

09f28d17

Use a protocol

2ad75ce0

Add intersection

b757221c

Invert logic

aa793a0c

Always intersect

21837d33

Gate on TypedDict

6616a7e6

Omit constraint

e03f0974

Remove it

0b51fd94

Use a separate protocol

75f3aed2

charliermarsh force pushed from 2d8d195e to 75f3aed2 66 days ago

charliermarsh marked this pull request as draft 66 days ago

[ty] Preserve present TypedDict keys during narrowing

b3884cdf

[ty] Preserve present-key protocol refinements

7a8731ea

Revert "[ty] Preserve present-key protocol refinements"

82a98b0b

charliermarsh marked this pull request as ready for review 66 days ago

astral-sh-bot requested a review from

AlexWaygood 66 days ago

simplify

af061493

AlexWaygood approved these changes on 2026-06-04

Add TODOs for present-key narrowing

37f7a020

charliermarsh enabled auto-merge (squash) 61 days ago

charliermarsh merged 0fd91a40 into main 61 days ago

charliermarsh deleted the charlie/td-required-keys branch 61 days ago

Reviewers

AlexWaygood

carljm

sharkdp

dcreager

ibraheemdev

Assignees

AlexWaygood

Labels

Milestone

No milestone

ruff [ty] Enable narrowing for unions of TypedDict #25188 Merged

[ty] Enable narrowing for unions of TypedDict #25188

ruff
[ty] Enable narrowing for unions of TypedDict
#25188

Merged