PR #5459 Refactor `StmtIf`: Formatter and Linter

Refactor `StmtIf`: Formatter and Linter #5459

konstin merged 33 commits into main from refator-if-statement-formatter

konstin requested a review from

MichaReiser 2 years ago

MichaReiser requested changes on 2023-07-03

MichaReiser requested a review from

MichaReiser 2 years ago

konstin force pushed from e20308fd to f348660d 2 years ago

konstin force pushed from f348660d to 6b8274a9 2 years ago

konstin added formatter

konstin force pushed from 90735a47 to ae67543d 2 years ago

konstin force pushed from 76599a28 to c440683f 2 years ago

konstin force pushed from 04bbaf51 to 67a6497f 2 years ago

konstin force pushed from 99106737 to a8e84428 2 years ago

konstin changed the title ~~Refactor `StmtIf`: Formatter~~ Refactor `StmtIf`: Formatter and Linter 2 years ago

konstin removed review request from

MichaReiser 2 years ago

konstin requested a review from

MichaReiser 2 years ago

MichaReiser approved these changes on 2023-07-17

Port `FormatStmtIf` to the new `StmtIf` layout

38f767f9

Some visitors

4efdd2f1

Update crates/ruff_python_formatter/src/statement/stmt_if.rs

f0e9987c

clarify FormatElifElseClause comment

1a6bdaee

Fix visitor

33663c48

Refactor `StmtIf`: Linter (#5460)

d075c2ea

Update json schema

96b4cac1

Fix TRY004 else bodies

9d29265c

Fix SIM116 else

2f652fc8

SIM116 else, right this time

f3945b93

Schema with all features

4c3381a7

TRY004 body

a5a400a2

Fix StmtIf visitor to fix B007

2d8b9596

Add custom visit_elif_else_clause

4a6cb5ed

Fix F811

1011fcf2

Fix SIM102 regression

d3930c71

Fix PLR5501

813ae5d8

override `CommentsVisitor::visit_elif_else_clause`

93680e9a

Update crates/ruff_python_ast/src/visitor/preorder.rs

7d09d345

Update crates/ruff_python_ast/src/visitor.rs

1c2f7138

Update crates/ruff_python_ast/src/stmt_if.rs

09add155

Update crates/ruff_python_ast/src/statement_visitor.rs

5614e723

Update crates/ruff_python_ast/src/source_code/comment_ranges.rs

c7c467c4

Remove outdated TODO

a1330eec

More visitor fixes from review

75339a2c

Make comment ranges a bit faster

68bc109b

clippy

1529f78a

Fix StmtIf with new visitors

c2e82f2c

Pull in the newest parser changes

0dea85e6

Fix instability in cpython

b58edebe

More type alias

92de058a

konstin force pushed from 04b37518 to 92de058a 2 years ago

clippy

c76541bb

Update to RustPython main with tag

ff9bd66a

konstin merged 730e6b2b into main 2 years ago

konstin deleted the refator-if-statement-formatter branch 2 years ago

Reviewers

MichaReiser

Assignees

No one assigned

Labels

formatter

Milestone

No milestone

ruff Refactor `StmtIf`: Formatter and Linter #5459 Merged

Refactor `StmtIf`: Formatter and Linter #5459

ruff
Refactor `StmtIf`: Formatter and Linter
#5459

Merged