PR #8835 New AST nodes for f-string elements

New AST nodes for f-string elements #8835

dhruvmanila merged 12 commits into main from dhruv/fstring-element

Base automatically changed from dhruv/remove-allow to main 2 years ago

dhruvmanila added internal

dhruvmanila force pushed from 50a15fa4 to 6b1a20e0 2 years ago

dhruvmanila force pushed from 6b1a20e0 to 2c0a7622 2 years ago

dhruvmanila force pushed from 2c0a7622 to 775e0baf 2 years ago

dhruvmanila force pushed from 775e0baf to 91db3758 2 years ago

dhruvmanila force pushed from 6075a38f to 8d52723d 2 years ago

dhruvmanila force pushed from 8d52723d to 7cf49997 2 years ago

dhruvmanila closed this 2 years ago

dhruvmanila reopened this 2 years ago

dhruvmanila force pushed from 18c8aed9 to a148ee90 2 years ago

dhruvmanila force pushed from a148ee90 to b7736bb3 2 years ago

dhruvmanila force pushed from b7736bb3 to baa2eac3 2 years ago

dhruvmanila force pushed from baa2eac3 to ebb8d449 2 years ago

dhruvmanila force pushed from ebb8d449 to b9aa0dac 2 years ago

MichaReiser commented on 2023-12-04

dhruvmanila force pushed from b9aa0dac to ac3b960c 2 years ago

dhruvmanila force pushed from ac3b960c to 4745626e 2 years ago

dhruvmanila force pushed from 4745626e to 297dc988 2 years ago

dhruvmanila force pushed from 297dc988 to df882367 2 years ago

dhruvmanila force pushed from df882367 to ddd8e9d0 2 years ago

dhruvmanila force pushed from ddd8e9d0 to f4ed639a 2 years ago

dhruvmanila force pushed from f4ed639a to 765c62d0 2 years ago

dhruvmanila marked this pull request as ready for review 2 years ago

dhruvmanila requested a review from

MichaReiser 2 years ago

MichaReiser requested a review from

charliermarsh 2 years ago

MichaReiser approved these changes on 2023-12-05

dhruvmanila force pushed from 765c62d0 to bd821b85 2 years ago

New AST node for f-string element

cc395c90

Update parser to use the new `FString*Element` nodes

698fa3c5

Update parser test snapshots

95da9fbd

Implement `AstNode` for `FString*Element` nodes

bcdd7dd1

Update visitor implementations for `FString*Element` nodes

50f46707

Update `ComparableExpr` with `FString*Element` nodes

9cc82874

Update AST helpers with `FString*Element` nodes

623d868c

Update code generator with `FString*Element` nodes

8bd17d29

chore: remove `FormattedValue` references

2e29353b

Update linter with `FString*Element` nodes

04d90d5f

Update linter tests and snapshots

a36eebd3

Update formatter with `FString*Element` nodes

b6be853e

dhruvmanila force pushed from bd821b85 to b6be853e 2 years ago

dhruvmanila commented on 2023-12-06

charliermarsh commented on 2023-12-07

charliermarsh approved these changes on 2023-12-07

dhruvmanila merged cdac90ef into main 2 years ago

dhruvmanila deleted the dhruv/fstring-element branch 2 years ago

Reviewers

charliermarsh

MichaReiser

Assignees

No one assigned

Labels

internal

Milestone

No milestone

ruff New AST nodes for f-string elements #8835 Merged

New AST nodes for f-string elements #8835

ruff
New AST nodes for f-string elements
#8835

Merged