PR #9266 [`pycodestyle`] Add blank line(s) rules (`E301`, `E302`, `E303`, `E304`, `E305`, `E306`)

Add V1 version.

hoel-bagard committed 1 year ago

Keep track of previous streak of blank lines to fix 301.

hoel-bagard committed 1 year ago

Fix 302.

hoel-bagard committed 1 year ago

Fix 305.

hoel-bagard committed 1 year ago

Fix 306.

hoel-bagard committed 1 year ago

Fix 303 regression.

hoel-bagard committed 1 year ago

Add snapshots.

hoel-bagard committed 1 year ago

Update nursery rules list

hoel-bagard committed 1 year ago

Add a non-error test and its corresponding fix.

hoel-bagard committed 1 year ago

Add a TODO comment.

hoel-bagard committed 1 year ago

Update snapshots following 06618c2.

hoel-bagard committed 1 year ago

Clippy fixes.

hoel-bagard committed 1 year ago

Store line.is_comment_only()'s result in a variable. Use config more.

hoel-bagard committed 1 year ago

Do not ignore first logical line when it comes to tracked vars.

hoel-bagard committed 1 year ago

Merge branch 'astral-sh:main' into add_blank_lines_E30_V2

hoel-bagard committed 1 year ago

Remove unnecessary check.

hoel-bagard committed 1 year ago

Update snapshots (Fix -> Safe fix)

hoel-bagard committed 1 year ago

Fix first logical line issue.

hoel-bagard committed 1 year ago

Fix false positive caused by a class's docstring.

hoel-bagard committed 1 year ago

Only trigger E302 on non-indented classes/functions.

hoel-bagard committed 1 year ago

Fix decorator linked false positive.

hoel-bagard committed 1 year ago

Fix E301 false positive.

hoel-bagard committed 1 year ago

Fix decorator + async false positive.

hoel-bagard committed 1 year ago

Fix E302 error message.

hoel-bagard committed 1 year ago

Improve E302's fix interaction with comments.

hoel-bagard committed 1 year ago

Fix E301 regression and improve E301 fix.

hoel-bagard committed 1 year ago

Fix E302 fix's interaction with comments.

hoel-bagard committed 1 year ago

Clippy fix.

hoel-bagard committed 1 year ago

Fix docstring + comment leading to false positive.

hoel-bagard committed 1 year ago

Fix E305 false positive for indented classes/defs

hoel-bagard committed 1 year ago

Make rules independent.

hoel-bagard committed 1 year ago

Fix typo.

hoel-bagard committed 1 year ago

Rule simplification.

hoel-bagard committed 1 year ago

Fix E306 false negative when using async or decorator.

hoel-bagard committed 1 year ago

Simplify/fix E301's condition.

hoel-bagard committed 1 year ago

Make if condition more readable.

hoel-bagard committed 1 year ago

Simplify E301's if condition.

hoel-bagard committed 1 year ago

Remove unnecessary clone.

hoel-bagard committed 1 year ago

Merge branch 'astral-sh:main' into add_blank_lines_E30_V2

hoel-bagard committed 1 year ago

Modify E303 to use top-levelness instead of class/def.

hoel-bagard committed 1 year ago

Remove unnecessary clone derive.

hoel-bagard committed 1 year ago

Update E306

hoel-bagard committed 1 year ago

is_first_logical_line -> is_not_first_logical_line to be able to derive Default.

hoel-bagard committed 1 year ago

Remove BlankLinesConfig struct and use module level constants instead.

hoel-bagard committed 1 year ago

Use an enum to keep track of class and fn status.

hoel-bagard committed 1 year ago

Remove for loop, clippy fixes.

hoel-bagard committed 1 year ago

Remove unnecessary Option from is_docstring.

hoel-bagard committed 1 year ago

Use an enum to keep track of what the line is following.

hoel-bagard committed 1 year ago

Update crates/ruff_linter/src/rules/pycodestyle/rules/logical_lines/blank_lines.rs

hoel-bagard committed 1 year ago

BlankLinesTrackingVars -> BlankLinesChecker

hoel-bagard committed 1 year ago

WIP

hoel-bagard committed 1 year ago

Started building LogicalLine replacement.

hoel-bagard committed 1 year ago

Mostly finished renaming variable.

hoel-bagard committed 1 year ago

Remove blank line counting in logical lines.

hoel-bagard committed 1 year ago

Bug fixes.

hoel-bagard committed 1 year ago

Clippy fixes.

hoel-bagard committed 1 year ago

Add comment.

hoel-bagard committed 1 year ago

Move the blank_lines outside the logical_lines module.

hoel-bagard committed 1 year ago

Merge with upstream.

hoel-bagard committed 1 year ago

Move check to the tokens' file.

hoel-bagard committed 1 year ago

Remove unused import.

hoel-bagard committed 1 year ago

Fix rule placement in the registry.

hoel-bagard committed 1 year ago

Ignore clippy warnings.

hoel-bagard committed 1 year ago

Split if conditions into multiple ifs.

hoel-bagard committed 1 year ago

Fix 2 false positives linked to indentation.

hoel-bagard committed 1 year ago

Fix false positive caused by bad async handling.

hoel-bagard committed 1 year ago

Add test fixture.

hoel-bagard committed 1 year ago

Remove async as a top level token.

hoel-bagard committed 1 year ago

Fix is_top_level_token docstring.

hoel-bagard committed 1 year ago

Use usize for preceding_blank_characters.

hoel-bagard committed 1 year ago

Use TokenKind instead of Tok

hoel-bagard committed 1 year ago

Use == comparison instead of matches! where possible

hoel-bagard committed 1 year ago

Use TokenKind::is_trivia to reduce nesting.

hoel-bagard committed 1 year ago

Remove dead if branch.

hoel-bagard committed 1 year ago

Update crates/ruff_linter/src/rules/pycodestyle/rules/blank_lines.rs

hoel-bagard committed 1 year ago

Give violations' u32 field a name and make it private.

hoel-bagard committed 1 year ago

Simplify and explain is_docstring flag detection.

hoel-bagard committed 1 year ago

Replace unwrap by expect.

hoel-bagard committed 1 year ago

check_content -> check_lines

hoel-bagard committed 1 year ago

Move BlankLinesChecker struct declaration closer to its implementation block.

hoel-bagard committed 1 year ago

Remove unnecessary clip allow.

hoel-bagard committed 1 year ago

Passing TokenKind by value.

hoel-bagard committed 1 year ago

Remove unnecessary clip allow (too many arguments).

hoel-bagard committed 1 year ago

Update crates/ruff_linter/src/rules/pycodestyle/rules/blank_lines.rs

hoel-bagard committed 1 year ago

Update crates/ruff_linter/src/rules/pycodestyle/rules/blank_lines.rs

hoel-bagard committed 1 year ago

Revert "Update crates/ruff_linter/src/rules/pycodestyle/rules/blank_lines.rs"

hoel-bagard committed 1 year ago

Fix visual indent.

hoel-bagard committed 1 year ago

Fix visual indent.

hoel-bagard committed 1 year ago

Revert unrelated variable name change.

hoel-bagard committed 1 year ago

Add tests with indentation made of 2 spaces, tabs and mixed spaces and tabs

hoel-bagard committed 1 year ago

Do not use an hard coded indent size.

hoel-bagard committed 1 year ago

Fix missing else branch

hoel-bagard committed 1 year ago

Remove outdated Async check.

hoel-bagard committed 1 year ago

Remove unecessary if.

hoel-bagard committed 1 year ago

Move follow docstring if block outside of comment only if block.

hoel-bagard committed 1 year ago

Remove unecessary comment check condition.

hoel-bagard committed 1 year ago

Only store the last token's end instead of full range.

hoel-bagard committed 1 year ago

Rename indent_level to indent_length

hoel-bagard committed 1 year ago

refactor: make current_blank_lines and current_blank_characters into local variables when building the logical line info

hoel-bagard committed 1 year ago

docs: add docstring to explain the difference between blank_lines and preceding_blank_lines

hoel-bagard committed 1 year ago

ruff [`pycodestyle`] Add blank line(s) rules (`E301`, `E302`, `E303`, `E304`, `E305`, `E306`) #9266 Merged

ruff
[`pycodestyle`] Add blank line(s) rules (`E301`, `E302`, `E303`, `E304`, `E305`, `E306`)
#9266

Merged