ruff
Allow arbitrary configuration options to be overridden via the CLI
#9599
Merged

Allow arbitrary configuration options to be overridden via the CLI #9599

AlexWaygood
AlexWaygood WIP
d73a453b
AlexWaygood Get it working with `--isolated`
159fada0
AlexWaygood Get it working without `--isolated`
7cd900c3
AlexWaygood i can spell
3cdbec7d
AlexWaygood Fix a couple build/test failures
0f2cc2cc
MichaReiser
MichaReiser commented on 2024-01-22
AlexWaygood Simplify `Configuration.transform()`
18daf07b
AlexWaygood Remove unnecessary special casing
721653de
AlexWaygood Just pass a `Vec` to `from_cli_options`
7bb72f50
BurntSushi
BurntSushi commented on 2024-01-22
AlexWaygood Misc review comments
e7a1d89c
AlexWaygood More docs cleanup
7c05cd5a
AlexWaygood use an `Arc`
26b7dc8c
AlexWaygood Use `clap` a little more for slightly prettier errors
59e6e0af
AlexWaygood
AlexWaygood commented on 2024-01-23
AlexWaygood Merge branch 'main' into arbitrary-cli-overrides
f33e91eb
AlexWaygood regen docs
cd6b4ce9
github-actions
AlexWaygood Improve error messages
3fb5d213
codspeed-hq
AlexWaygood Improve error messages more
2568265f
AlexWaygood Merge branch 'main' into arbitrary-cli-overrides
d6a18fea
AlexWaygood Add tests for some failure cases
83798902
AlexWaygood Also test the formatter
366cd1b8
AlexWaygood Many more tests
2583136e
AlexWaygood spelling
981210c1
AlexWaygood Simplify some code
3bfcae2a
AlexWaygood
AlexWaygood Further improve error messages
e32dd0a1
AlexWaygood cargo fmt
aca4af51
AlexWaygood couple more tests
446517b2
AlexWaygood Docs
c39fbd6b
AlexWaygood AlexWaygood marked this pull request as ready for review 1 year ago
AlexWaygood
MichaReiser MichaReiser added cli
MichaReiser
MichaReiser approved these changes on 2024-01-29
AlexWaygood Apply suggestions from code review
ebd72865
AlexWaygood add a newline
d771243a
AlexWaygood Fix compile; address more Micha comments
be48c4fa
AlexWaygood Couple more comments
8f79c656
AlexWaygood Return `&Path` from `config_file()`
1cc613c5
AlexWaygood Improve docs for `--config`
c12bb11d
AlexWaygood regen docs
a8806912
AlexWaygood Delete `Configuration::transform()`
59e07c3a
AlexWaygood Rename the enum and its variants
7ec9e8a0
AlexWaygood More consistent naming for arguments that take instances of `ConfigAr…
de846ba4
AlexWaygood Better dev docs for the `ConfigArguments` struct
893f214a
AlexWaygood Rework docs; improve test
0ccc608b
AlexWaygood cargo fmt
b12a9c71
AlexWaygood Don't return `clap::Error` after the initial argument-parsing phase
1501eeb4
AlexWaygood
AlexWaygood AlexWaygood requested a review from MichaReiser MichaReiser 1 year ago
AlexWaygood AlexWaygood requested a review from zanieb zanieb 1 year ago
MichaReiser
MichaReiser approved these changes on 2024-01-30
AlexWaygood
AlexWaygood Various cleanups
e46c06a5
AlexWaygood Merge branch 'main' into arbitrary-cli-overrides
e39aa393
AlexWaygood Merge branch 'main' into arbitrary-cli-overrides
e1a3328f
AlexWaygood Fixup some issues after merging in `main`
d83cfa5d
AlexWaygood Fix remaining test failures
138c6c3a
zanieb
AlexWaygood
AlexWaygood Merge branch 'main' into arbitrary-cli-overrides
e500b39f
AlexWaygood Merge branch 'main' into arbitrary-cli-overrides
acca9095
AlexWaygood Fixup after merge
5e83ef88
AlexWaygood Merge branch 'arbitrary-cli-overrides' of https://github.com/AlexWayg…
18da11bf
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
AlexWaygood ``
0b0917be
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
zanieb
zanieb commented on 2024-02-06
AlexWaygood Address some Zanie comments
5074bffc
AlexWaygood Merge branch 'arbitrary-cli-overrides' of https://github.com/AlexWayg…
c6019f74
AlexWaygood Add a test for overriding a deprecated CLI option via the CLI
7d6f9dd1
AlexWaygood regen docs
bb2e6eef
AlexWaygood Use `insta-filters` for the tests where the tempdir path is included …
7739440e
AlexWaygood Multiline tips instead of multiple tips
88e7273a
AlexWaygood Make more concise
bccab4e7
AlexWaygood Differentiate between TOML syntax errors and valid TOML that we don't…
6eea7977
AlexWaygood
AlexWaygood AlexWaygood requested a review from zanieb zanieb 1 year ago
charliermarsh
charliermarsh
charliermarsh commented on 2024-02-09
charliermarsh
charliermarsh commented on 2024-02-09
charliermarsh
charliermarsh commented on 2024-02-09
charliermarsh
charliermarsh commented on 2024-02-09
charliermarsh
charliermarsh commented on 2024-02-09
charliermarsh
charliermarsh approved these changes on 2024-02-09
charliermarsh
charliermarsh commented on 2024-02-09
AlexWaygood Address Charlie's docs review
983e5aa9
AlexWaygood Add a transitional sentence
789d1d0d
AlexWaygood
AlexWaygood AlexWaygood enabled auto-merge (squash) 1 year ago
disabled auto-merge 1 year ago
Manually disabled by user
AlexWaygood Merge branch 'main' into arbitrary-cli-overrides
0f8a5831
AlexWaygood AlexWaygood merged 8ec56277 into main 1 year ago
AlexWaygood AlexWaygood deleted the arbitrary-cli-overrides branch 1 year ago
ofek

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone