babel
Flow opaque type 6.x backport
#6081
Merged

Flow opaque type 6.x backport #6081

hzoo merged 5 commits into babel:master from 6.x
jbrown215
jbrown2157 years ago👍 6
Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Deprecations? No
Spec Compliancy? Yes
Tests Added/Pass? Yes
Fixed Tickets N/A
License MIT
Doc PR No
Dependency Changes None

Backport of #5990. Depends on babel/babylon#644

I added all the same tests (with some slight changes) to babel-generator, babel-plugin-transform-flow-strip-types, and babel-plugin-transform-flow-comments.

Note: When using the current state of 6.x on both babel and babylon, there were two tests errors:
bin/babel-node v8Flag-dashed-with-param and bin/babel-node v8Flag-underscored-with-param

This diff will also have those errors

jbrown215 Flow opaque type backport
9d1af50d
jbrown215 Add tests for strip types, comments, and babel-generator
36babe2d
jbrown215 Fix failing tests, run scripts
3d2a1776
jbrown215 jbrown215 changed the title 6.x Flow opaque type 6.x backport 7 years ago
xtuc xtuc added 6.x: backport
xtuc xtuc added area: flow
xtuc xtuc added PR: Spec Compliance :eyeglasses:
bradennapier
bradennapier7 years ago

Looking forward to this!

jbrown215 jbrown215 changed the base branch from 6.x to master 7 years ago
jbrown215 Bump babylon to 6.18.0
d499b5e8
Merge branch 'master' into 6.x
98639b7c
jbrown215
jbrown2157 years ago

@hzoo changed target to master and bumped babylon in babel-core, babel-generator, babel-traverse, and babel-types to 6.18.0

hzoo hzoo merged c28465e0 into master 7 years ago
jbrown215
jbrown2157 years ago

@hzoo: the build is broken for the same reason it was broken in the pr to 7.0. I'm going to backport @existentialism's fix (#6031) and put up another PR to master

hzoo
hzoo7 years ago (edited 7 years ago)

cool, thanks. it's fine locally?

jbrown215
jbrown2157 years ago

problem repros locally, but with changes from #6031 everything is fine

lock lock added outdated
lock lock locked as resolved and limited conversation to collaborators 5 years ago

Login to write a write a comment.

Login via GitHub

Reviewers
No reviews
Assignees
No one assigned
Labels
Milestone