cri-o
Update golangci-lint to v1.60.3 for better go 1.23 compatibility
#8535
Merged

Update golangci-lint to v1.60.3 for better go 1.23 compatibility #8535

saschagrunert
saschagrunert276 days ago

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

There seems to be an issue where the linter runs indefinitely. This should be fixed by using the latest release.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None
saschagrunert Update golangci-lint to v1.60.3 for better go 1.23 compatibility
dd0cb08d
saschagrunert saschagrunert requested a review from mrunalp mrunalp 276 days ago
openshift-ci openshift-ci added release-note-none
openshift-ci openshift-ci added kind/failing-test
openshift-ci openshift-ci added dco-signoff: yes
openshift-ci openshift-ci requested a review from hasan4791 hasan4791 276 days ago
openshift-ci openshift-ci requested a review from sohankunkerkar sohankunkerkar 276 days ago
openshift-ci openshift-ci added approved
codecov
codecov276 days ago (edited 273 days ago)

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.24%. Comparing base (a5e3268) to head (dd0cb08).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8535      +/-   ##
==========================================
- Coverage   49.25%   49.24%   -0.02%     
==========================================
  Files         153      153              
  Lines       17254    17254              
==========================================
- Hits         8499     8497       -2     
- Misses       7687     7688       +1     
- Partials     1068     1069       +1     
saschagrunert
saschagrunert276 days ago

/retest

kwilczynski
kwilczynski276 days ago

/approve
/lgtm

openshift-ci openshift-ci assigned kwilczynski kwilczynski 276 days ago
openshift-ci openshift-ci added lgtm
openshift-ci
openshift-ci276 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

saschagrunert
saschagrunert276 days ago

/retest

saschagrunert
saschagrunert276 days ago

/retest

saschagrunert
saschagrunert273 days ago

/override ci/prow/e2e-aws-ovn

openshift-ci
openshift-ci273 days ago

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-bot openshift-merge-bot merged 167c0567 into main 273 days ago
saschagrunert saschagrunert deleted the lint branch 273 days ago

Login to write a write a comment.

Login via GitHub

Assignees
Labels
Milestone