feat(ext/ffi): Callbacks #14663
littledivy
merged
72 commits into
denoland:main
from
aapoalas:feat/ffi-register-callback-rewrite
aapoalas
changed the title
Start rewrite
291ca64b
Further work
6f955d07
Scope in stack or not
352d98ee
Functioning synchronous registered callbacks
15261ea8
Don't borrow across callback call
f98424ff
Move forward with parameter types in FFI callbacks
8b460011
Adapt, does not function properly
7a10c38b
Use serde_v8::Value
2335d2a7
fmt
f63cebaa
Pick ops stuff from sqlite bindings
cd8260d9
Try async fixing
78a12cda
Work work
4de8ef8b
Somewhat handle nonblocking calls
8a6dace9
Not really well working
90c932d4
Fix lifetime issues with ffi_parse_args
3c10894e
Error handling
e3b55f62
async work, thanks divy
8e637976
Return lifetimes
15d0fbfd
fmt & lint
69ae9bfb
fmt & lint
48f439d3
Actually pass RegisteredCallback RID to FFI
23f58000
Actually functioning registered callbacks!
6971d16a
fmt & lint
e271cc7c
Remove likely unnecessary active scope tracking from ffi calls
98110af1
ops: support a result returning a future returning a result.
ccdd1221
reenable nonblocking ops as hybrids
283dc154
Merge branch 'main' into feat/ffi-register-callback-rewrite
579015c3
Rewrite ext/ffi to return serde_v8::Value
4fd175f9
Fix
f4a8fe24
Move parameter validity checks to JS side
f1eed633
Fix nonblocking calls by reverting them to json::Value and U32x2 retu…
7478eade
Add extensive FFI baseline benchmarks
c98241b2
fmt & lint
6c0ffe87
Minor improvements
297dab71
Fix tests FFI calls
87e10ca3
Merge branch 'main' into feat/ffi-register-callback-rewrite
f357ceaa
fmt
7b2c176b
Fix more FFI ops call signatures
3d53899b
Fix check_unstable2 usage
2f370c9f
Fix mistaken Symbol usage with ptr FFI calls
e6fad7ae
Fix buffer returning with quite manual V8 value picking
06dee1f5
Add callback tests
c29d8fd9
fmt & lint
69eec016
Expose registered callback pointer values
6db458b1
Use primordials
84ddbda0
Improve deno_ffi_callback inline comment
bcc5caf9
Catch and rethrow errors from FFI callbacks
77f3f517
littledivy
commented
on 2022-06-13
Fix idiosyncracies, add some types at least
ce5b3cb7
Use pointer values for RegisteredCallbacks, removing resource_table u…
3f117709
Fix errors in i64 / u64 callback return values
53bfa8fc
Review comments
7d75f7db
Rename RegisteredCallback to UnsafeCallback
3b8a881d
Use specific APIs for ints
6ac34713
Use specific APIs for ints in callbacks, avoid serde_v8 in callback p…
a7814635
Implicit drop
0c678526
Review fixes, light renaming
d936617f
Safety notice on UnsafeCallbackResource close()
798ebf5c
littledivy
commented
on 2022-06-15
Missing permissions check, remove left-over op, add notice about Unsa…
56004f22
Return v8::Value directly in UnsafeCallback constructor
3cf98c44
Merge branch 'main' into feat/ffi-register-callback-rewrite
3582d940
littledivy
approved these changes
on 2022-06-16
Merge branch 'main' into feat/ffi-register-callback-rewrite
179074da
Fix UnsafeCallback types and add extensive type tests
9f5c8df4
Merge branch 'main' into feat/ffi-register-callback-rewrite
a84c3f3a
Fix format
fc2f2e14
Remove unnecessary try-catch from deno_ffi_callback
27accd9f
piscisaureus
commented
on 2022-06-17
piscisaureus
commented
on 2022-06-17
Undo unrelated formatting changes
4131bfa8
Merge branch 'main' into feat/ffi-register-callback-rewrite
2eeffd04
Merge branch 'main' of github.com:denoland/deno into feat/ffi-registe…
bd4c1f75
Add test for error propogation
5184ddd4
Format
40aac23a
throwCallback.close()
0780dbcc
Merge branch 'main' into feat/ffi-register-callback-rewrite
3218386f
Login to write a write a comment.
Login via GitHub