deno
fix(ext/node): rewrite Windows TTY reading to match libuv (console mode, encoding, raw + line mode)
#32999
Merged

fix(ext/node): rewrite Windows TTY reading to match libuv (console mode, encoding, raw + line mode) #32999

bartlomieju
bartlomieju fix(ext/node): fix Windows TTY console mode restoration, output encod…
2cc8415e
bartlomieju fix(ext/node): revert read loop to single-shot to prevent blocking
5027918c
bartlomieju fix(ext/node): use PeekConsoleInputW to avoid ReadFile blocking on no…
346d95e3
bartlomieju fix(ext/node): rewrite Windows TTY raw mode read to use ReadConsoleIn…
c4a31fe0
bartlomieju fix: add missing Windows fields to new_tty() constructor
5d10b815
bartlomieju fix: use explicit autoref for raw pointer field slicing
4bcdaded
bartlomieju fix(ext/node): gate Windows TTY read on input availability
b18f544d
bartlomieju fix(ext/node): use RegisterWaitForSingleObject for async console input
c30e0b50
bartlomieju fix: collapse nested if per clippy::collapsible_if
b9be61dc
bartlomieju
bartlomieju bartlomieju changed the title fix(ext/node): fix Windows TTY console mode, output encoding, and read blocking fix(ext/node): fix Windows TTY console mode, output encoding, and raw mode reading 111 days ago
littledivy
littledivy approved these changes on 2026-03-26
bartlomieju fix(ext/node): wake event loop on Windows TTY write to flush prompt
349e6c8d
bartlomieju fix(ext/node): also wake event loop from read_start_tty on Windows
5a142158
bartlomieju fix(ext/node): offload line-mode TTY read to worker thread on Windows
2eee47ee
bartlomieju fix(ext/node): drain write queue before spawning line-read thread, re…
6d050ac8
bartlomieju fix(ext/node): add TTY tests, fix Ctrl+C test, drop unneeded write drain
bfb8e452
bartlomieju bartlomieju changed the title fix(ext/node): fix Windows TTY console mode, output encoding, and raw mode reading fix(ext/node): rewrite Windows TTY reading to match libuv (console mode, encoding, raw + line mode) 111 days ago
bartlomieju fix: extract LineReadResult type alias to satisfy clippy::type_comple…
055a1266
kajukitli
bartlomieju fix: tear down Windows async read machinery in stop_tty before closin…
acdc89d5
littledivy
littledivy approved these changes on 2026-03-26
kajukitli
bartlomieju bartlomieju merged eb436571 into main 111 days ago
bartlomieju bartlomieju deleted the fix/windows-tty-regression branch 111 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone