deno
fix(ext/node): create net.Socket from file descriptors
#33150
Merged

fix(ext/node): create net.Socket from file descriptors #33150

bartlomieju merged 19 commits into main from feat/net-socket-fd-option
bartlomieju
bartlomieju refactor(ext/node): rewrite Pipe.open(fd) to use raw fd ops
8464f728
bartlomieju fix: Windows compilation for op_node_register_fd, add ref/unref, add …
e69a966c
bartlomieju fix: replace spec tests with unit tests, format
29ab86ad
bartlomieju fix: use TCP instead of unix sockets in pipe fd tests
28a6ef23
bartlomieju fix: track ref state in FdStreamBase, replace tests with pipe specs
73f3273d
bartlomieju fix: restore proper Pipe.open(fd) spec tests
d1032c62
bartlomieju fix: add Windows Pipe.open(fd) test using _pipe() FFI
cdb86c46
bartlomieju fix: reject duplicate fd in op_node_register_fd, add cross-platform p…
893f80c6
bartlomieju fix: add safety comments for Windows unsafe blocks in op_node_create_…
6a946d98
bartlomieju fmt
01679218
bartlomieju feat(ext/node): implement net.Socket({ fd }) option
ae4f61b3
bartlomieju fix(ext/node): fix child_process extra stdio pipe fd alignment
89fcd0ec
bartlomieju Merge remote-tracking branch 'origin/main' into feat/net-socket-fd-op…
4ee15e4a
bartlomieju bartlomieju changed the title feat(ext/node): implement net.Socket({ fd }) option fix(ext/node): create net.Socket from file descriptors 138 days ago
bartlomieju
bartlomieju commented on 2026-04-02
bartlomieju
bartlomieju commented on 2026-04-02
bartlomieju refactor(ext/node): clean up toDenoStdio in child_process
d9f3a78e
bartlomieju
bartlomieju test: enable test-child-process-fork-stdio node_compat test
8d79c25b
bartlomieju refactor(ext/node): remove resource table lookup from op_node_guess_h…
639d4b08
bartlomieju fix: split net_socket_fd test for Windows compatibility
ffb8117c
miracatbot
miracatbot commented on 2026-04-02
miracatbot
miracatbot requested changes on 2026-04-02
miracatbot
miracatbot requested changes on 2026-04-02
bartlomieju fix(ext/node): clarify fd ownership in op_node_register_fd, add test
0f64051d
miracatbot
miracatbot approved these changes on 2026-04-02
bartlomieju Merge remote-tracking branch 'origin/main' into feat/net-socket-fd-op…
7522483a
bartlomieju bartlomieju enabled auto-merge (squash) 138 days ago
bartlomieju bartlomieju merged 4e6eb1e1 into main 138 days ago
bartlomieju bartlomieju deleted the feat/net-socket-fd-option branch 138 days ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
Milestone