PR #188 Refactor EditInPlace

Refactor EditInPlace #188

sandhose merged 10 commits into main from quenting/refactor-edit-in-place

sandhose requested a review 1 year ago

sandhose removed review request 1 year ago

sandhose requested a review from

dbkr 1 year ago

sandhose requested a review from

robintown 1 year ago

sandhose marked this pull request as draft 1 year ago

WIP: refactor edit in place

17546250

Use a state machine for the EditInPlace state

0817e3d9

Control the focus state in the component, not in CSS

6c419fab

Update screenshots

df2a80dc

sandhose force pushed from 652752cc to 414404d2 1 year ago

sandhose force pushed from 414404d2 to 8ae9103b 1 year ago

Use the existing button component

fc0434a8

sandhose force pushed from 8ae9103b to fc0434a8 1 year ago

sandhose marked this pull request as ready for review 1 year ago

Go back to the initial state when clicking the cancel button

7807925f

Lint

45793e61

Prevent submitting the form if the user has not yet entered any text

a87d520f

Make the event handlers a little better

279a7fe1

Fix the LoadingMessage component name

71566e26

t3chguy approved these changes on 2024-06-20

sandhose merged 49df1cb2 into main 1 year ago

Reviewers

t3chguy

dbkr

robintown

Assignees

No one assigned

Labels

None yet

Milestone

No milestone