element-x-android
Code quality: warnings are errors and enable more Detekt rules.
#935
Merged
Merged
Code quality: warnings are errors and enable more Detekt rules. #935
bmarty
merged
33 commits into
develop
from
feature/bma/noWarnings
Ignore compilation warnings, disabled by default.
39b17017
Ci will not ignore compilation warnings.
089fc8b4
Fix warning (comment out temporary dead code)
a88ac632
Fix warning ('when' is exhaustive so 'else' is redundant here)
9fbdef4b
Fix warning (Build.VERSION.SDK_INT < Build.VERSION_CODES.Q here)
1f3efdfe
Fix warning (remove dead code)
202268ae
Fix warning (suppress, no sure I want to delete this class right now)
b072872c
Fix warning (comment out dead code due to notification actions not ac…
0f4af79f
Fix warning (suppress, no sure I want to delete this class right now)
c7222e29
Fix warning (suppress unused param for now)
8d6e1a23
Fix warning (suppress unused param for now)
a7f53247
Fix warning (suppress unused param for now, EAX does not support stic…
0a512cae
Fix warning (suppress unused param for now)
518f6903
Fix warning (suppress unused param for now)
e5d2e294
Create sheetStateForPreview to avoid code duplication.
2163c1db
Fix warning (there is a TODO)
6a69207f
Fix warning (we will handle error case later)
f738864e
Fix warning (keep the same format for all methods)
e67c7f32
Fix warning (there is a TODO)
e2322259
Stop using deprecated LocalBroadcastManager. We will implement the co…
d7f8aa53
Fix warning (bottom sheet still not previewable correctly in screensh…
65ad642f
Enable detekt rule `UnusedPrivateMember` and cleanup the code.
24ece8c4
Enable detekt rules `UnusedParameter` and `UnusedPrivateProperty` and…
86756dbc
Enable detekt rules `VariableNaming` and cleanup the code.
a8ed8b7a
Enable detekt rules `TopLevelPropertyNaming` and cleanup the code.
e918d6af
Remove detekt rules about ViewModels.
08a7287e
Enable detekt rules `UnusedImports` and cleanup the code.
2928073e
Enable detekt rules `UnnecessaryParentheses` and cleanup the code.
c75eabbc
Enable more detekt rules
73ae59a3
bmarty
changed the title
Fix compilation issue
1be26c9f
Merge branch 'develop' into feature/bma/noWarnings
5e2e03f0
Add a shortcut to ensure that ./gradlew check will prevent having war…
ce22aecb
Ensure the release script will exist in case of failure.
5eb70215
julioromano
approved these changes
on 2023-07-21
Login to write a write a comment.
Login via GitHub