Add profile stats to the CPU profiler #5340
kenzieschmoll
merged
3 commits into
flutter:master
from
kenzieschmoll:cpu-stats
Add profile stats to the CPU profiler
c83fc08f
kenzieschmoll
commented
on 2023-03-02
packages/devtools_app/lib/src/screens/profiler/cpu_profiler.dart
| 365 | 367 | } | |
| 366 | 368 | } | |
| 367 | 369 | ||
| 368 | class DisplayTreeGuidelinesToggle extends StatelessWidget { |
kenzieschmoll2 years agoall the deletes over here were moved to profiler_controls.dart with no functional changes. git diff picked this up weird unfortunately.
kenzieschmoll
commented
on 2023-03-02
packages/devtools_app/lib/src/screens/profiler/cpu_profiler.dart
| 366 | 368 | } | |
| 367 | 369 | ||
| 368 | class DisplayTreeGuidelinesToggle extends StatelessWidget { | ||
| 369 | const DisplayTreeGuidelinesToggle(); | ||
| 370 | // TODO(kenz): one improvement we could make on this is to show the denominator | ||
| 371 | // for filtered profiles (e.g. 'Sample count: 10/14), or to at least show the |
kenzieschmoll2 years agoreview all the additions from here to the bottom of the file as new code - not a modification of code on the left.
kenzieschmoll
commented
on 2023-03-02
packages/devtools_app/lib/src/screens/profiler/panes/controls/profiler_controls.dart
| 1 | // Copyright 2019 The Chromium Authors. All rights reserved. |
kenzieschmoll2 years agono functional changes to this file. all moves from cpu_profiler.dart
fix pr link
7f51949b
bkonyi
approved these changes
on 2023-03-02
bkonyi2 years ago
LGTM with a couple of comments
Conversation is marked as resolved
Conversation is marked as resolved
review comments and test
5f2ebbfc
Login to write a write a comment.
Work towards #3861
While I was here, I also created a new file
profiler_controls.dartand pulled some controls from cpu_profiler.dart out into the new file. This was to make the cpu_profiler.dart file more manageable.