devtools
[deep link] Update loading UI
#6732
Merged
Overview
Commits
4
Changes
View On GitHub

[deep link] Update loading UI #6732

hannah-hyj merged 4 commits into flutter:master from hannah-hyj:loading
hannah-hyj
hannah-hyj1 year ago

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR.

Please add a note to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

hannah-hyj 1
c2133159
hannah-hyj hannah-hyj requested a review 1 year ago
hannah-hyj hannah-hyj removed review request 1 year ago
hannah-hyj hannah-hyj requested a review from CoderDake CoderDake 1 year ago
hannah-hyj hannah-hyj requested a review from kenzieschmoll kenzieschmoll 1 year ago
hannah-hyj hannah-hyj removed review request from CoderDake CoderDake 1 year ago
hannah-hyj hannah-hyj added release-notes-not-required
hannah-hyj lint
57ba9977
kenzieschmoll
kenzieschmoll commented on 2023-11-20
Conversation is marked as resolved
Show resolved
packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart
9090 builder: (context, linkDatas, _) {
9191 if (linkDatas == null) {
92 return const CenteredCircularProgressIndicator();
92
 return Center(
kenzieschmoll1 year ago

You should be able to delete this widget since you have mainAxisAlignment: MainAxisAlignment.center,. You may need to also add a centered crossAxisAlignment to the Column

kenzieschmoll
kenzieschmoll commented on 2023-11-20
Conversation is marked as resolved
Show resolved
packages/devtools_app/lib/src/screens/deep_link_validation/select_project_view.dart
89 crossAxisAlignment: CrossAxisAlignment.start,
90 children: [
91 Text(
92
 'Project loading',
kenzieschmoll1 year ago

should this have a trailing ellipsis ... to match the style of the loading message above?

kenzieschmoll
kenzieschmoll commented on 2023-11-20
Conversation is marked as resolved
Show resolved
packages/devtools_app/lib/src/screens/deep_link_validation/select_project_view.dart
99 ),
100 Text(
101 'First time loading will take longer time than usual',
102
 style: Theme.of(context).subtleTextStyle,
kenzieschmoll1 year ago

put Theme.of(context) into a local var since it is used more than once

kenzieschmoll
kenzieschmoll commented on 2023-11-20
Conversation is marked as resolved
Show resolved
packages/devtools_app/lib/src/screens/deep_link_validation/select_project_view.dart
98 child: const LinearProgressIndicator(),
99 ),
100 Text(
101
 'First time loading will take longer time than usual',
kenzieschmoll1 year ago

wording nit: "The first load will take longer than usual"

kenzieschmoll
kenzieschmoll commented on 2023-11-20
Conversation is marked as resolved
Show resolved
packages/devtools_app/lib/src/screens/deep_link_validation/select_project_view.dart
101112 Padding(
102113 padding: const EdgeInsets.all(defaultSpacing),
103 child: child,
114 child: Text(
115
 'Pick a flutter project from your local file to check all deep links status',
kenzieschmoll1 year ago

wording: "Pick a local flutter project to check the status of all deep links."

kenzieschmoll
kenzieschmoll commented on 2023-11-20
Conversation is marked as resolved
Show resolved
packages/devtools_app/lib/src/screens/deep_link_validation/select_project_view.dart
8383 @override
8484 Widget build(BuildContext context) {
85 Widget? child;
8685 if (_retrievingFlutterProject) {
87 child = const CenteredCircularProgressIndicator(size: _kMessageSize);
88 } else {
89 child = Text(
90 'Pick a flutter project from your local file to check all deep links status',
91 textAlign: TextAlign.center,
92 style: TextStyle(
93 color: Theme.of(context).textTheme.displayLarge!.color,
86
 return Center(
kenzieschmoll1 year ago

You should be able to remove this Center widget

hannah-hyj Merge branch 'master' of https://github.com/flutter/devtools into loa…
91348978
hannah-hyj 1
f452439c
hannah-hyj hannah-hyj requested a review from kenzieschmoll kenzieschmoll 1 year ago
kenzieschmoll
kenzieschmoll approved these changes on 2023-12-04
hannah-hyj hannah-hyj merged 04f9775a into master 1 year ago
hannah-hyj hannah-hyj deleted the loading branch 1 year ago

Login to write a write a comment.

Login via GitHub

Reviewers
Assignees
No one assigned
Labels
release-notes-not-required
Milestone
No milestone
Terms Of Use Privacy Policy Refund Policy Impressum