llama.cpp
common: Intentionally leak logger instance to fix hanging on Windows
#22273

Merged

common: Intentionally leak logger instance to fix hanging on Windows #22273

ggerganov merged 13 commits into ggml-org:master from rillomas:fix-hang-on-windows

Changed to leak logger singleton to prevent hanging on Windows

e300d919

rillomas requested a review 197 days ago

Fix comment

c827365e

ggerganov added merge ready

pwilkin approved these changes on 2026-04-23

ggerganov removed merge ready

rillomas marked this pull request as draft 196 days ago

Stopped using static vector

3d11a9b1

rillomas marked this pull request as ready for review 196 days ago

Change so all logs are output before exit

0876586d

rillomas requested a review from

ggerganov 196 days ago

github-actions added testing

rillomas marked this pull request as draft 195 days ago

Added debug logging

0835bb64

added more logging

aec92930

Added logging

c18ced25

Explicitly free logger to avoid hanging on Win

29dcd977

rillomas changed the title ~~common: Changed to leak logger singleton to prevent hanging on Windows~~ tests: Fix hanging on logger unit test 193 days ago

rillomas changed the title ~~tests: Fix hanging on logger unit test~~ common: Intentionally leak logger instance to fix hanging on Windows 193 days ago

Reverted to leak logger instance again

f79a93c7

rillomas marked this pull request as ready for review 193 days ago

Merge remote-tracking branch 'origin/master' into fix-hang-on-windows

3eddfcd7

Removed debug log and fixed comment

c18bf246

Fixed comment

84f4e3b9

ggerganov added merge ready

pwilkin approved these changes on 2026-04-28

ggerganov commented on 2026-04-29

Apply suggestion from @ggerganov

fca7973d

ggerganov merged 7b95ea5d into master 191 days ago

rillomas deleted the fix-hang-on-windows branch 191 days ago

Reviewers

pwilkin

ggerganov

Assignees

No one assigned

Labels

testing merge ready

Milestone

No milestone

llama.cpp common: Intentionally leak logger instance to fix hanging on Windows #22273 Merged

common: Intentionally leak logger instance to fix hanging on Windows #22273

llama.cpp
common: Intentionally leak logger instance to fix hanging on Windows
#22273

Merged