PR #29557 grammar : optimize matching with left factoring

grammar : optimize matching with left factoring #29557

ggerganov merged 14 commits into ggml-org:master from o7si:issue-29457

github-actions added testing

o7si marked this pull request as ready for review 48 days ago

o7si requested a review from

ggerganov 48 days ago

o7si requested a review 11 days ago

o7si marked this pull request as draft 11 days ago

grammar : limit the number of alternatives

393a707e

grammar : introduce an AST for grammar parsing

84f3b57c

o7si force pushed from 3f8800e5 to 84f3b57c 11 days ago

o7si changed the title ~~grammar : limit the number of alternatives~~ grammar : add an AST and limit alternatives 10 days ago

o7si marked this pull request as ready for review 10 days ago

grammar : revert AST refactor and alternatives limit

8139cbae

grammar: optimize big grammar matching by using left-factorization

85ebb897

grammar : preserve character class boundaries during left factoring

7f10bc27

grammar : prevent infinite expansion during left factoring

daa2414c

o7si changed the title ~~grammar : add an AST and limit alternatives~~ grammar : optimize matching with left factoring 9 days ago

grammar : use ASCII characters in comments

d9ba014d

grammar : test empty suffixes after left factoring

c40e3545

grammar : deduplicate left factoring logic

9eb84cae

grammar : add comments

e6d2dafd

grammar : use number parameters and clarify RSS output

38d587a6

grammar : clarify character class test names

bf4e8619

pwilkin approved these changes on 2026-11-07

aldehir approved these changes on 2026-11-08

grammar : remove performance benchmark

678832c1

ggerganov commented on 2026-11-12

grammar : share immutable rules

2011bf54

ggerganov approved these changes on 2026-11-12

ggerganov added merge ready

ggerganov merged 108f73ad into master 2 days ago

Reviewers

ggerganov

aldehir

pwilkin

Assignees

No one assigned

Labels

testing merge ready

Milestone

No milestone

llama.cpp grammar : optimize matching with left factoring #29557 Merged

grammar : optimize matching with left factoring #29557

llama.cpp
grammar : optimize matching with left factoring
#29557

Merged