llama.cpp
ggml : update CUDA/Metal radix Top-K to make tied selections deterministic
#31084
Merged

ggml : update CUDA/Metal radix Top-K to make tied selections deterministic #31084

sanmai
github-actions github-actions added testing
github-actions github-actions added Vulkan
github-actions github-actions added ggml
github-actions github-actions added CUDA
ServeurpersoCom
sanmai ggml : fix for the radix TOP_K thread timing bug
09fdff62
sanmai sanmai force pushed from ea2c43a3 to 09fdff62 6 days ago
sanmai make the key an ordered 64-bit pair
e3c72088
sanmai a rewrite without shift-skip logic
61cce0fa
sanmai fix casts
722116f8
github-actions github-actions added Apple Metal
sanmai warp-contiguous layout
87ff2828
sanmai reduce the scope removing vulkan+metal changes
e8fb7cf5
sanmai turn it off for Metal/ROCm, note about cub::DeviceTopK
19a17316
sanmai fix the hip build
e61e87e1
sanmai skip Vulkan as well
5f703e3c
sanmai sanmai removed Vulkan
sanmai sanmai removed Apple Metal
sanmai sanmai changed the title ggml : possible fix for the radix TOP_K thread timing bug ggml : update CUDA radix Top-K to make tied selections deterministic 5 days ago
sanmai
sanmai sanmai marked this pull request as ready for review 5 days ago
sanmai sanmai requested a review from ggerganov ggerganov 5 days ago
sanmai sanmai requested a review 5 days ago
ServeurpersoCom
ServeurpersoCom
ORippler
ORippler commented on 2026-11-05
sanmai popc lambda from fattn
108e254e
ServeurpersoCom
sanmai do block_cols math in int64_t
0a374bd4
ORippler
sanmai
ServeurpersoCom
sanmai
sanmai commented on 2026-11-05
sanmai
sanmai make it allowlist bc SYCL looks non deterministic too
dddb7951
sanmai
ggerganov
ggerganov commented on 2026-11-06
ggerganov ggml : make Metal radix Top-K tied selections deterministic
81ea5f5b
ggerganov tests : enable deterministic top-k check on Metal, add radix-path tie…
a4d0db49
ggerganov ggerganov requested a review 4 days ago
ServeurpersoCom
github-actions github-actions added Apple Metal
ServeurpersoCom
ServeurpersoCom
ServeurpersoCom approved these changes on 2026-11-06
ggerganov ggml : use coalesced accesses in the Metal radix Top-K compaction
c2889ab6
ggerganov tests : remove the extra top-k tie and perf cases
efcf2de2
ggerganov
ggerganov approved these changes on 2026-11-06
ggerganov
ServeurpersoCom
ggerganov
ORippler
ORippler approved these changes on 2026-11-06
ServeurpersoCom metal: scan the radix bins and warp totals with a simdgroup
599da5be
ServeurpersoCom tests: enable the deterministic top-k check on ROCm
6f4b7498
ServeurpersoCom
ServeurpersoCom cuda: remove the redundant radix top-k counter reset
ce8aeaec
ServeurpersoCom
sanmai sanmai changed the title ggml : update CUDA radix Top-K to make tied selections deterministic ggml : update CUDA/Metal radix Top-K to make tied selections deterministic 2 days ago
sanmai sanmai added merge ready
ggerganov ggerganov merged 57d04820 into master 2 days ago
sanmai sanmai deleted the ggml/top-k-deterministic-ties branch 1 day ago

Login to write a write a comment.

Login via GitHub

Assignees
No one assigned
Labels
Milestone