PR #7449 Fix phi3 chat template confusion with zephyr

Fix phi3 chat template confusion with zephyr #7449

ngxson merged 8 commits into ggml-org:master from master

Fix phi3 template matching vs zephyr

bde2e760

Add regression test for new phi3 chat template

45108ecc

github-actions added testing

tristandruyen changed the title ~~Fix phi3 template matching vs zephyr~~ Fix phi3 chat template confusion with zephyr 1 year ago

tristandruyen marked this pull request as ready for review 1 year ago

mofosyne added model

mofosyne added Review Complexity : Low

tristandruyen commented on 2024-05-22

Implement review suggestions

a142933e

tristandruyen requested a review from

ngxson 1 year ago

Fix phi3 jinja test templates & match by <|end|>

037af53b

ngxson commented on 2024-05-23

ngxson approved these changes on 2024-05-23

Apply suggestion

05e6bc6c

Add all phi3 template variants in tests

a9bbb119

ngxson requested changes on 2024-05-23

Remove unneeded message trimming

85ed87eb

ngxson approved these changes on 2024-05-23

Fix tests to not expect trimmed messages

3574d636

ngxson merged 007489e8 into master 1 year ago

Reviewers

ngxson

Assignees

No one assigned

Labels

model testing Review Complexity : Low

Milestone

No milestone