graphql-js
Test recursion avoidance correctly
#29
Merged

Test recursion avoidance correctly #29

dittos
dittos9 years ago

DataType is unknown type, so ...Frag fragment spread was ignored and recursion was not tested correctly.

Additional question: is it intended to just ignore a fragment on the unknown type?

dittos Test recursion avoidance correctly
0b4fb811
facebook-github-bot facebook-github-bot added CLA Signed
leebyron leebyron merged 858e6933 into master 9 years ago
leebyron
leebyron9 years ago

Great catch, thanks!

leebyron
leebyron9 years ago

Yes, that's correct. This is testing the behavior of non-verified queries, to ensure behavior is correct in the case a query is executed before being validated.

If validated, the fragment recursion would have been caught before execution, as would the mistyped type information.

Login to write a write a comment.

Login via GitHub

Reviewers
No reviews
Assignees
No one assigned
Labels
Milestone