graphql-js
move variable position validation for OneOf to `VariablesInAllowedPositionRule`
#4194

Merged

move variable position validation for OneOf to `VariablesInAllowedPositionRule` #4194

yaacovCR merged 1 commit into graphql:main from yaacovCR:one-of-tweaks

yaacovCR marked this pull request as ready for review 1 year ago

yaacovCR requested a review 1 year ago

yaacovCR force pushed from 8ccde451 to cb33ff13 1 year ago

yaacovCR changed the title ~~OneOf Validation Suggestions~~ move OneOf variable position validation to `VariablesInAllowedPositionRule` 1 year ago

yaacovCR requested a review from

benjie 1 year ago

yaacovCR added PR: bug fix 🐞

yaacovCR changed the title ~~move OneOf variable position validation to `VariablesInAllowedPositionRule`~~ move variable position validation for OneOf to `VariablesInAllowedPositionRule` 1 year ago

yaacovCR requested a review from

JoviDeCroock 1 year ago

benjie dismissed these changes on 2024-09-18

yaacovCR requested a review from

benjie 1 year ago

Move variable position validation for OneOf fields to VariablesInAllo…

a3dbb175

yaacovCR force pushed from cb33ff13 to a3dbb175 1 year ago

yaacovCR dismissed their stale review 1 year ago

separate PR to add additional tests, they belong to ValuesOfCorrectType, while this PR is related to oneOf and VariablesInAllowedPosition

Thompson1985 approved these changes on 2024-10-06

JoviDeCroock approved these changes on 2024-10-15

yaacovCR merged 858aa325 into main 1 year ago

yaacovCR deleted the one-of-tweaks branch 1 year ago

benjie commented on 2024-10-17

Reviewers

JoviDeCroock

Thompson1985

benjie

Assignees

No one assigned

Labels

PR: bug fix 🐞

Milestone

No milestone

graphql-js move variable position validation for OneOf to `VariablesInAllowedPositionRule` #4194 Merged

move variable position validation for OneOf to `VariablesInAllowedPositionRule` #4194

graphql-js
move variable position validation for OneOf to `VariablesInAllowedPositionRule`
#4194

Merged